From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Matthias Fend <matthias.fend@emfend.at>, barebox@lists.infradead.org Subject: Re: i2c: Rockchip i2c controller support Date: Tue, 3 May 2022 13:13:18 +0200 [thread overview] Message-ID: <9bcb9c38-248f-5370-4d9c-0619545e6eec@pengutronix.de> (raw) In-Reply-To: <01aea3ad-d18b-fa9f-ea11-e6bae8750695@emfend.at> Hello Matthias, On 03.05.22 12:11, Matthias Fend wrote: > Hi, > > it looks to me like the rockchip_i2c_xfer function returns 0 if everything was successful, but shouldn't the i2c master_xfer functions return the number of messages actually processed? > > I was just wondering about reading sources and can't do real world testing due to lack of hardware... I think you're right. I tested this only with the RK808 PMIC on the Nano Pi N10 and noticed no problems, but it seems that was just me being lucky. I'll give it a test with fixed return value and send a patch in the coming days. Thanks for the review! Cheers, Ahmad > > ~Matthias > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-05-03 11:15 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-03 10:11 Matthias Fend 2022-05-03 11:13 ` Ahmad Fatoum [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9bcb9c38-248f-5370-4d9c-0619545e6eec@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=matthias.fend@emfend.at \ --subject='Re: i2c: Rockchip i2c controller support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox