mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* i2c: Rockchip i2c controller support
@ 2022-05-03 10:11 Matthias Fend
  2022-05-03 11:13 ` Ahmad Fatoum
  0 siblings, 1 reply; 2+ messages in thread
From: Matthias Fend @ 2022-05-03 10:11 UTC (permalink / raw)
  To: barebox; +Cc: a.fatoum

Hi,

it looks to me like the rockchip_i2c_xfer function returns 0 if 
everything was successful, but shouldn't the i2c master_xfer functions 
return the number of messages actually processed?

I was just wondering about reading sources and can't do real world 
testing due to lack of hardware...

  ~Matthias

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: i2c: Rockchip i2c controller support
  2022-05-03 10:11 i2c: Rockchip i2c controller support Matthias Fend
@ 2022-05-03 11:13 ` Ahmad Fatoum
  0 siblings, 0 replies; 2+ messages in thread
From: Ahmad Fatoum @ 2022-05-03 11:13 UTC (permalink / raw)
  To: Matthias Fend, barebox

Hello Matthias,

On 03.05.22 12:11, Matthias Fend wrote:
> Hi,
> 
> it looks to me like the rockchip_i2c_xfer function returns 0 if everything was successful, but shouldn't the i2c master_xfer functions return the number of messages actually processed?
> 
> I was just wondering about reading sources and can't do real world testing due to lack of hardware...

I think you're right. I tested this only with the RK808 PMIC on the Nano Pi N10
and noticed no problems, but it seems that was just me being lucky.

I'll give it a test with fixed return value and send a patch in the
coming days.

Thanks for the review!

Cheers,
Ahmad

> 
>  ~Matthias
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-03 11:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-03 10:11 i2c: Rockchip i2c controller support Matthias Fend
2022-05-03 11:13 ` Ahmad Fatoum

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git