mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] phy: core: Make 'phy_optional_get' return NULL when not implemented
@ 2021-10-20  8:39 Daniel Brát
  2021-11-01  9:00 ` Sascha Hauer
  2022-03-03  9:53 ` Sascha Hauer
  0 siblings, 2 replies; 11+ messages in thread
From: Daniel Brát @ 2021-10-20  8:39 UTC (permalink / raw)
  To: barebox; +Cc: Daniel Brát

Make 'phy_optional_get' return NULL instead of ERR_PTR(-ENOSYS) when the
CONFIG_GENERIC_PHY is not enabled. It makes more sense to return NULL instead
of straight up throwing a error since the function has 'optional' in its name.
This also fixes dwc2 usb driver which would previously fail inside its probe
function despite being able to function without a phy just fine.

Signed-off-by: Daniel Brát <danek.brat@gmail.com>
---
 include/linux/phy/phy.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
index 679ce6e42..321e546f9 100644
--- a/include/linux/phy/phy.h
+++ b/include/linux/phy/phy.h
@@ -195,7 +195,7 @@ static inline struct phy *phy_get(struct device_d *dev, const char *string)
 static inline struct phy *phy_optional_get(struct device_d *dev,
 					   const char *string)
 {
-	return ERR_PTR(-ENOSYS);
+	return NULL;
 }
 
 static inline struct phy *of_phy_get_by_phandle(struct device_d *dev,
-- 
2.17.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-03-03  9:55 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20  8:39 [PATCH] phy: core: Make 'phy_optional_get' return NULL when not implemented Daniel Brát
2021-11-01  9:00 ` Sascha Hauer
     [not found]   ` <CAMHeXxMJYC2q4Hs7zd9A=5-KsXyFUtTshMVoZZC2nJUah=LtjA@mail.gmail.com>
2021-11-01 19:04     ` Trent Piepho
2021-11-02  7:40     ` Sascha Hauer
2021-11-03 22:35       ` Trent Piepho
2021-11-04 20:02         ` Sascha Hauer
2021-11-04 21:40           ` Trent Piepho
2021-11-08  9:10             ` Sascha Hauer
2021-11-08 22:01               ` Trent Piepho
2021-11-11 13:09                 ` Sascha Hauer
2022-03-03  9:53 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox