mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: has@pengutronix.de
Subject: Re: [PATCH 1/2] partitions: efi: register guid device parameter for disk GUID
Date: Thu, 30 Jun 2022 15:19:28 +0200	[thread overview]
Message-ID: <bfd75b6d-d5f7-195a-d0e1-997a883255a6@pengutronix.de> (raw)
In-Reply-To: <20220630122457.4009827-1-a.fatoum@pengutronix.de>

On 30.06.22 14:24, Ahmad Fatoum wrote:
> We already register an nt_signature parameter for MBR partitions.
> Register an equivalent guid parameter for GPT partitions as well.
> This is less critical because disk GUID isn't used for root=
> Linux boot argument computation, as each partition has its own
> PARTUUID. It's still useful to allow shell scripts to check
> against it to detect e.g. a factory flash image.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Please dismiss. Premature emailing.

> ---
>  common/partitions/efi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/common/partitions/efi.c b/common/partitions/efi.c
> index 848bed22610f..0f3f790539cd 100644
> --- a/common/partitions/efi.c
> +++ b/common/partitions/efi.c
> @@ -446,6 +446,7 @@ static void efi_partition(void *buf, struct block_device *blk,
>  	}
>  
>  	snprintf(blk->cdev.uuid, sizeof(blk->cdev.uuid), "%pUl", &gpt->disk_guid);
> +	dev_add_param_string_fixed(blk->dev, "guid", blk->cdev.uuid);
>  
>  	nb_part = le32_to_cpu(gpt->num_partition_entries);
>  


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      parent reply	other threads:[~2022-06-30 13:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30 12:24 Ahmad Fatoum
2022-06-30 12:24 ` [PATCH 2/2] commands: implement devlookup to find device behind device file Ahmad Fatoum
2022-06-30 13:19 ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfd75b6d-d5f7-195a-d0e1-997a883255a6@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=has@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox