mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Yunus Bas <Y.Bas@phytec.de>
To: "michael.riesch@wolfvision.net" <michael.riesch@wolfvision.net>,
	"sha@pengutronix.de" <sha@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH v2] commands: of_property: Extend command usage on external dtb
Date: Tue, 29 Jun 2021 11:33:47 +0000	[thread overview]
Message-ID: <d9f643320cc9af6c1ad3fb8170cdd8f6de0dcfb6.camel@phytec.de> (raw)
In-Reply-To: <f692a44f-e182-0091-3c73-5d4191ce7d62@wolfvision.net>

Hi Michael,

Am Dienstag, dem 29.06.2021 um 11:25 +0200 schrieb Michael Riesch:
> Hello Sascha,
> 
> On 6/28/21 10:23 PM, Sascha Hauer wrote:
> > On Fri, Jun 25, 2021 at 06:05:55PM +0200, Yunus Bas wrote:
> > > The scope of the of_property command is limited to the internal
> > > devicetree
> > > only. There is the possibility to add fixtures to postpone the
> > > operation
> > > until boot and after the kernel DTB is already loaded, but this
> > > does not
> > > cover the case when the property value needs to be phandle
> > > adresses
> > > defined in the external DTB, since assigned values are evaluated
> > > immediatly.
> > > 
> > > This patch extends the of_property-command to use it on external
> > > DTB's as
> > > well. In case fixup is not used, the changes will also affect the
> > > original
> > > data.
> > > 
> > > Signed-off-by: Yunus Bas <y.bas@phytec.de>
> > > ---
> > > Changes in v2:
> > > - Use %m instead of "%s", strerror(errno)
> > > - Not fixing devicetree anymore before save
> > > ---
> > >  commands/of_property.c | 74 ++++++++++++++++++++++++++++++++----
> > > ------
> > >  1 file changed, 57 insertions(+), 17 deletions(-)
> > 
> > Applied, thanks
> > 
> > Sascha
> 
> on the current next this patch collides with "fdt: Check blob size
> during unflattening" as the call
> 
> > > +               root = of_unflatten_dtb(fdt);
> 
> requires now an extra size argument.
> 
> There is a variable "size" before the call. Is it safe to use it?

The size variable is read from the dtb, so I think it's also intended
to use it. Shall I send a v3 or can you apply the change?

Regards, Yunus

> 
> Regards, Michael

-- 
Mit freundlichen Grüßen
Yunus Bas

-Software Engineer-
PHYTEC Messtechnik GmbH
Robert-Koch-Str. 39
55129 Mainz
Germany
Tel.: +49 (0)6131 9221- 466
Web: www.phytec.de

Sie finden uns auch auf: Facebook, LinkedIn, Xing, YouTube

PHYTEC Messtechnik GmbH | Robert-Koch-Str. 39 | 55129 Mainz, Germany
Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber |
Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 266500608, DE
149059855
This E-Mail may contain confidential or privileged information. If you
are not the intended recipient (or have received this E-Mail in error)
please notify the sender immediately and destroy this E-Mail. Any
unauthorized copying, disclosure or distribution of the material in
this E-Mail is strictly forbidden.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2021-06-29 11:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 16:05 Yunus Bas
2021-06-28 20:23 ` Sascha Hauer
2021-06-29  9:25   ` Michael Riesch
2021-06-29 11:33     ` Yunus Bas [this message]
2021-06-29 12:04       ` [PATCH] fixup! " Michael Riesch
2021-07-03 20:42         ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9f643320cc9af6c1ad3fb8170cdd8f6de0dcfb6.camel@phytec.de \
    --to=y.bas@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=michael.riesch@wolfvision.net \
    --cc=sha@pengutronix.de \
    --subject='Re: [PATCH v2] commands: of_property: Extend command usage on external dtb' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox