Re: [PATCH v2] commands: of_property: Extend command usage on external dtb

[Michael Riesch <michael.riesch@wolfvision.net>]

Hello Sascha,

On 6/28/21 10:23 PM, Sascha Hauer wrote:
> On Fri, Jun 25, 2021 at 06:05:55PM +0200, Yunus Bas wrote:
>> The scope of the of_property command is limited to the internal devicetree
>> only. There is the possibility to add fixtures to postpone the operation
>> until boot and after the kernel DTB is already loaded, but this does not
>> cover the case when the property value needs to be phandle adresses
>> defined in the external DTB, since assigned values are evaluated
>> immediatly.
>>
>> This patch extends the of_property-command to use it on external DTB's as
>> well. In case fixup is not used, the changes will also affect the original
>> data.
>>
>> Signed-off-by: Yunus Bas <y.bas@phytec.de>
>> ---
>> Changes in v2:
>> - Use %m instead of "%s", strerror(errno)
>> - Not fixing devicetree anymore before save
>> ---
>>  commands/of_property.c | 74 ++++++++++++++++++++++++++++++++----------
>>  1 file changed, 57 insertions(+), 17 deletions(-)
> 
> Applied, thanks
> 
> Sascha

on the current next this patch collides with "fdt: Check blob size
during unflattening" as the call

>> +		root = of_unflatten_dtb(fdt);

requires now an extra size argument.

There is a variable "size" before the call. Is it safe to use it?

Regards, Michael

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox