mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Sascha Hauer <sha@pengutronix.de>, Yunus Bas <y.bas@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] commands: of_property: Extend command usage on external dtb
Date: Tue, 29 Jun 2021 11:25:01 +0200	[thread overview]
Message-ID: <f692a44f-e182-0091-3c73-5d4191ce7d62@wolfvision.net> (raw)
In-Reply-To: <20210628202314.GR9782@pengutronix.de>

Hello Sascha,

On 6/28/21 10:23 PM, Sascha Hauer wrote:
> On Fri, Jun 25, 2021 at 06:05:55PM +0200, Yunus Bas wrote:
>> The scope of the of_property command is limited to the internal devicetree
>> only. There is the possibility to add fixtures to postpone the operation
>> until boot and after the kernel DTB is already loaded, but this does not
>> cover the case when the property value needs to be phandle adresses
>> defined in the external DTB, since assigned values are evaluated
>> immediatly.
>>
>> This patch extends the of_property-command to use it on external DTB's as
>> well. In case fixup is not used, the changes will also affect the original
>> data.
>>
>> Signed-off-by: Yunus Bas <y.bas@phytec.de>
>> ---
>> Changes in v2:
>> - Use %m instead of "%s", strerror(errno)
>> - Not fixing devicetree anymore before save
>> ---
>>  commands/of_property.c | 74 ++++++++++++++++++++++++++++++++----------
>>  1 file changed, 57 insertions(+), 17 deletions(-)
> 
> Applied, thanks
> 
> Sascha

on the current next this patch collides with "fdt: Check blob size
during unflattening" as the call

>> +		root = of_unflatten_dtb(fdt);

requires now an extra size argument.

There is a variable "size" before the call. Is it safe to use it?

Regards, Michael

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-06-29  9:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 16:05 Yunus Bas
2021-06-28 20:23 ` Sascha Hauer
2021-06-29  9:25   ` Michael Riesch [this message]
2021-06-29 11:33     ` Yunus Bas
2021-06-29 12:04       ` [PATCH] fixup! " Michael Riesch
2021-07-03 20:42         ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f692a44f-e182-0091-3c73-5d4191ce7d62@wolfvision.net \
    --to=michael.riesch@wolfvision.net \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    --cc=y.bas@phytec.de \
    --subject='Re: [PATCH v2] commands: of_property: Extend command usage on external dtb' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox