mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH v1] ARM: dts: at91-microchip-ksz9477-evb: start using kernel DT
@ 2022-04-07  8:59 Oleksij Rempel
  2022-04-07 12:26 ` Ahmad Fatoum
  2022-04-12  8:57 ` Sascha Hauer
  0 siblings, 2 replies; 4+ messages in thread
From: Oleksij Rempel @ 2022-04-07  8:59 UTC (permalink / raw)
  To: barebox; +Cc: Oleksij Rempel

This DT is mainlined to the kernel. Now we can start using kernel
version. At same time it will fix SPI and KSZ switch detection.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/dts/at91-microchip-ksz9477-evb.dts | 140 +-------------------
 1 file changed, 4 insertions(+), 136 deletions(-)

diff --git a/arch/arm/dts/at91-microchip-ksz9477-evb.dts b/arch/arm/dts/at91-microchip-ksz9477-evb.dts
index b7e619a363..3762361b53 100644
--- a/arch/arm/dts/at91-microchip-ksz9477-evb.dts
+++ b/arch/arm/dts/at91-microchip-ksz9477-evb.dts
@@ -1,27 +1,10 @@
-/*
- * at91-microchip-ksz9477-evb.dts - Device Tree file for the EVB-KSZ9477 board
- *
- *  Copyright (C) 2014 Atmel,
- *		  2014 Nicolas Ferre <nicolas.ferre@atmel.com>
- *		  2018 Ahmad Fatoum <a.fatoum@pengutronix.de>
- *
- * Licensed under GPLv2 or later.
- */
+/* SPDX-License-Identifier: GPL-2.0 */
 /dts-v1/;
-#include <arm/sama5d36.dtsi>
+#include <arm/at91-sama5d3_ksz9477_evb.dts>
 #include "sama5d3.dtsi"
 
 / {
-	model = "Microchip EVB-KSZ9477";
-	compatible = "atmel,sama5d3-ksz9477-evb", "atmel,sama5d3", "atmel,sama5";
-
-	aliases {
-		mmc0 = &mmc0;
-	};
-
 	chosen {
-		stdout-path = &dbgu;
-
 		environment {
 			compatible = "barebox,environment";
 			device-path = &mmc0, "partname:0";
@@ -34,121 +17,6 @@
 	reg = <0x20000000 0x10000000>;
 };
 
-&pinctrl {
-	board {
-		pinctrl_mmc0_cd: mmc0_cd {
-			atmel,pins =
-				<AT91_PIOE 0 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
-		};
-
-		pinctrl_spi_ksz: spi_ksz {
-			atmel,pins =
-				<
-				AT91_PIOB 28 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH
-				AT91_PIOC 31 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH
-				>;
-		};
-	};
-};
-
-&slow_xtal {
-	clock-frequency = <32768>;
-};
-
-&main_xtal {
-	clock-frequency = <12000000>;
-};
-
-&dbgu {
-	status = "okay";
-};
-
-&macb0 {
-	phy-mode = "rgmii";
-	gpios = <&pioB 28 GPIO_ACTIVE_LOW>;
-	status = "okay";
-
-	fixed-link {
-		speed = <1000>;
-		full-duplex;
-	};
-};
-
-&mmc0 {
-	pinctrl-0 = <&pinctrl_mmc0_clk_cmd_dat0 &pinctrl_mmc0_dat1_3 &pinctrl_mmc0_dat4_7 &pinctrl_mmc0_cd>;
-	status = "okay";
-	slot@0 {
-		reg = <0>;
-		bus-width = <8>;
-		cd-gpios = <&pioE 0 GPIO_ACTIVE_LOW>;
-	};
-};
-
-&pmc {
-	main: mainck {
-		clock-frequency = <12000000>;
-	};
-};
-
-&spi1 {
-	pinctrl-0 = <&pinctrl_spi_ksz>;
-	cs-gpios = <&pioC 25 0>;
-	id = <1>;
-	status = "okay";
-
-	ksz9477: ksz9477@0 {
-		compatible = "microchip,ksz9477", "microchip,ksz9893";
-		reg = <0>;
-
-		/* Bus clock is 132 MHz. */
-		spi-max-frequency = <44000000>;
-		spi-cpha;
-		spi-cpol;
-		gpios = <&pioB 28 GPIO_ACTIVE_LOW>;
-		status = "okay";
-
-		ports {
-			#address-cells = <1>;
-			#size-cells = <0>;
-
-			port@0 {
-				reg = <0>;
-				label = "lan0";
-			};
-
-			port@1 {
-				reg = <1>;
-				label = "lan1";
-			};
-
-			port@2 {
-				reg = <2>;
-				label = "lan2";
-			};
-
-			port@3 {
-				reg = <3>;
-				label = "lan3";
-			};
-
-			port@4 {
-				reg = <4>;
-				label = "lan4";
-			};
-
-			port@5 {
-				reg = <5>;
-				label = "cpu";
-				ethernet = <&macb0>;
-				phy-mode = "rgmii-id";
-
-				fixed-link {
-					speed = <1000>;
-					full-duplex;
-				};
-			};
-
-			/* port 6 is connected to eth0 */
-		};
-	};
+&reg_vcc_mmc0 {
+	status = "disabled";
 };
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] ARM: dts: at91-microchip-ksz9477-evb: start using kernel DT
  2022-04-07  8:59 [PATCH v1] ARM: dts: at91-microchip-ksz9477-evb: start using kernel DT Oleksij Rempel
@ 2022-04-07 12:26 ` Ahmad Fatoum
  2022-04-07 12:45   ` Oleksij Rempel
  2022-04-12  8:57 ` Sascha Hauer
  1 sibling, 1 reply; 4+ messages in thread
From: Ahmad Fatoum @ 2022-04-07 12:26 UTC (permalink / raw)
  To: Oleksij Rempel, barebox

On 07.04.22 10:59, Oleksij Rempel wrote:
> This DT is mainlined to the kernel. Now we can start using kernel
> version. At same time it will fix SPI and KSZ switch detection.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---

>  / {
> -	model = "Microchip EVB-KSZ9477";
> -	compatible = "atmel,sama5d3-ksz9477-evb", "atmel,sama5d3", "atmel,sama5";
> -
> -	aliases {
> -		mmc0 = &mmc0;
> -	};

Doesn't this change the name of the MMC device?

> +&reg_vcc_mmc0 {
> +	status = "disabled";
>  };

Why?



-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] ARM: dts: at91-microchip-ksz9477-evb: start using kernel DT
  2022-04-07 12:26 ` Ahmad Fatoum
@ 2022-04-07 12:45   ` Oleksij Rempel
  0 siblings, 0 replies; 4+ messages in thread
From: Oleksij Rempel @ 2022-04-07 12:45 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Thu, Apr 07, 2022 at 02:26:18PM +0200, Ahmad Fatoum wrote:
> On 07.04.22 10:59, Oleksij Rempel wrote:
> > This DT is mainlined to the kernel. Now we can start using kernel
> > version. At same time it will fix SPI and KSZ switch detection.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> 
> >  / {
> > -	model = "Microchip EVB-KSZ9477";
> > -	compatible = "atmel,sama5d3-ksz9477-evb", "atmel,sama5d3", "atmel,sama5";
> > -
> > -	aliases {
> > -		mmc0 = &mmc0;
> > -	};
> 
> Doesn't this change the name of the MMC device?

It is done by arch/arm/dts/sama5d3.dtsi
which is still included by this file.

> > +&reg_vcc_mmc0 {
> > +	status = "disabled";
> >  };
> 
> Why?

mmc0 is not working if this regulator is enabled and suddenly I do not have
enough time resources to investigate what exactly is wrong with it.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] ARM: dts: at91-microchip-ksz9477-evb: start using kernel DT
  2022-04-07  8:59 [PATCH v1] ARM: dts: at91-microchip-ksz9477-evb: start using kernel DT Oleksij Rempel
  2022-04-07 12:26 ` Ahmad Fatoum
@ 2022-04-12  8:57 ` Sascha Hauer
  1 sibling, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2022-04-12  8:57 UTC (permalink / raw)
  To: Oleksij Rempel; +Cc: barebox

On Thu, Apr 07, 2022 at 10:59:33AM +0200, Oleksij Rempel wrote:
> This DT is mainlined to the kernel. Now we can start using kernel
> version. At same time it will fix SPI and KSZ switch detection.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/dts/at91-microchip-ksz9477-evb.dts | 140 +-------------------
>  1 file changed, 4 insertions(+), 136 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-12  8:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07  8:59 [PATCH v1] ARM: dts: at91-microchip-ksz9477-evb: start using kernel DT Oleksij Rempel
2022-04-07 12:26 ` Ahmad Fatoum
2022-04-07 12:45   ` Oleksij Rempel
2022-04-12  8:57 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox