mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Stefan Kerkmann <s.kerkmann@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: "open list:BAREBOX" <barebox@lists.infradead.org>
Subject: Re: [PATCH 0/2] PBL: constructor fixes
Date: Thu, 20 Aug 2026 09:14:27 +0200	[thread overview]
Message-ID: <dbabb0d8-03a9-452a-b5df-a38cf389b180@pengutronix.de> (raw)
In-Reply-To: <0c26bfcc-deb4-400c-aa46-e20f839d4194@pengutronix.de>

Hi,

On 8/19/26 17:01, Sascha Hauer wrote:
> On 2026-08-19 16:16, Ahmad Fatoum wrote:
>> Hi,
>>
>> On 8/19/26 4:12 PM, Stefan Kerkmann wrote:
>>> Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
>>> ---
>>> Stefan Kerkmann (2):
>>>       ARM/ARM64/RISC-V: pbl: guard constructor support
>>>       ARM64: setup_c: abi safe link register storage
>>
>> if these are applied after what's in next, we would have intermittent
>> breakage when doing a bisect right?
>>
>> I would suggest either turning these into fixups or just resend the
>> whole series.
> 
> I just squashed them into the original commit. But next time, yes, you
> can send --fixup patches for patches in next.
> 

Thanks, I missed the bisectability requirement for this series. For the setup_c
patch I actually send an amend patch to include it in the original series with:

git send-email HEAD^ --to="Sascha Hauer <s.hauer@pengutronix.de>" --to="\"open
list:BAREBOX\" <barebox@lists.infradead.org>" --cc="Stefan Kerkmann
<s.kerkmann@pengutronix.de>"
--in-reply-to="<20260817-feature-pbl-get-time-ns-v3-2-9874c1438855@pengutronix.de>"

But it maybe wasn't picked up by b4 at the time the original merge happened?

> I just learned there's also --fixup=amend:<commit> for replacing the
> original commit message along with the fixup. There's even
> --fixup=reword:<commit> for just rewording the commit message without
> changing the patch content.
> 
> Sascha
> 
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 

Best regards,
Stefan

-- 
Pengutronix e.K.                       | Stefan Kerkmann             |
Steuerwalder Str. 21                   | https://www.pengutronix.de/ |
31137 Hildesheim, Germany              | Phone: +49-5121-206917-128  |
Amtsgericht Hildesheim, HRA 2686       | Fax:   +49-5121-206917-9    |




  reply	other threads:[~2026-08-20  8:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 14:12 Stefan Kerkmann
2026-08-19 14:12 ` [PATCH 1/2] ARM/ARM64/RISC-V: pbl: guard constructor support Stefan Kerkmann
2026-08-19 14:12 ` [PATCH 2/2] ARM64: setup_c: abi safe link register storage Stefan Kerkmann
2026-08-19 14:16 ` [PATCH 0/2] PBL: constructor fixes Ahmad Fatoum
2026-08-19 15:01   ` Sascha Hauer
2026-08-20  7:14     ` Stefan Kerkmann [this message]
2026-08-20  7:18       ` Sascha Hauer
2026-08-20  7:24         ` Stefan Kerkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbabb0d8-03a9-452a-b5df-a38cf389b180@pengutronix.de \
    --to=s.kerkmann@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox