From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>,
barebox@lists.infradead.org
Subject: Re: [PATCH] serial: ns16550: Reuse 48MHz default clock definition for non-DT OMAP boards
Date: Tue, 28 Jun 2022 10:23:01 +0200 [thread overview]
Message-ID: <f7faf1d6-0c24-189d-81db-a3a9340b64ce@pengutronix.de> (raw)
In-Reply-To: <20220628080414.28960-1-eagle.alexander923@gmail.com>
On 28.06.22 10:04, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> - if (!IS_ENABLED(CONFIG_OFDEVICE))
> + if (!IS_ENABLED(CONFIG_OFDEVICE) || !np)
Nitpick:
struct device_node *np = dev_of_node(dev);
if (!np)
is equivalent, but a bit less verbose.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-06-28 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 8:04 Alexander Shiyan
2022-06-28 8:23 ` Ahmad Fatoum [this message]
2022-06-29 7:15 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7faf1d6-0c24-189d-81db-a3a9340b64ce@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox