From: Stefan Kerkmann <s.kerkmann@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH 5/6] arm: dts: karo: add karo imx8mp-karo-qsxp-qsbase4
Date: Mon, 11 Mar 2024 14:25:55 +0100 [thread overview]
Message-ID: <fdde2d67-547c-4d12-baac-0779351fda59@pengutronix.de> (raw)
In-Reply-To: <b7b5f896-0b67-42fb-85ac-e00fdb97387b@pengutronix.de>
Hello Ahmad,
On 11.03.24 11:05, Ahmad Fatoum wrote:
> On 11.03.24 10:10, Stefan Kerkmann wrote:
>> +/dts-v1/;
>> +
>> +#include "imx8mp-karo-qsxp-ml81.dts"
>> +
>> +&{/} {
>
> While not wrong, this is unnecessary. We know that there is a / already.
>
Ack.
>> + model = "Ka-Ro electronics QSXP-ML81-QSBASE4 (NXP i.MX8MP) Board";
>> + compatible = "karo,imx8mp-qsxp-ml81-qsbase4", "karo,imx8mp-qsxp-ml81", "fsl,imx8mp";
>
> Ok, this confuses me. I thought QSXP is the SoM. What's ML81?
The official part number from karo is `QSXP-ML81`, it is just not
mentioned upfront on their product page - but you'll see it under
`Varianten` at https://www.karo-electronics.de/qsxp#c12158. Therefore I
vote to keep the `ml81` part.
>
>
>> +&usdhc2 {
>> + status = "disabled";
>> +};
>
> Nitpick: Should be disabled in SoM, as it requires outside hardware to be functional.
>
Ack.
>> +
>> +&iomuxc {
>> + pinctrl_eqos: eqosgrp {
>> + fsl,pins = <
>> + MX8MP_IOMUXC_SAI2_RXC__GPIO4_IO22 0x140 /* PHY reset */
>> + MX8MP_IOMUXC_ENET_MDC__ENET_QOS_MDC 0x142
>> + MX8MP_IOMUXC_ENET_MDIO__ENET_QOS_MDIO 0x142
>> + MX8MP_IOMUXC_ENET_TXC__CCM_ENET_QOS_CLOCK_GENERATE_TX_CLK 0x40000016
>> + MX8MP_IOMUXC_ENET_TD0__ENET_QOS_RGMII_TD0 0x016
>> + MX8MP_IOMUXC_ENET_TD1__ENET_QOS_RGMII_TD1 0x016
>> + MX8MP_IOMUXC_ENET_TD2__ENET_QOS_RGMII_TD2 0x016
>> + MX8MP_IOMUXC_ENET_TD3__ENET_QOS_RGMII_TD3 0x016
>> + MX8MP_IOMUXC_ENET_TX_CTL__ENET_QOS_RGMII_TX_CTL 0x016
>> + MX8MP_IOMUXC_ENET_RD0__ENET_QOS_RGMII_RD0 0x110 /* MODE0 */
>> + MX8MP_IOMUXC_ENET_RD1__ENET_QOS_RGMII_RD1 0x150 /* MODE1 */
>> + MX8MP_IOMUXC_ENET_RD2__ENET_QOS_RGMII_RD2 0x150 /* MODE2 */
>> + MX8MP_IOMUXC_ENET_RD3__ENET_QOS_RGMII_RD3 0x150 /* MODE3 */
>> + MX8MP_IOMUXC_ENET_RXC__CCM_ENET_QOS_CLOCK_GENERATE_RX_CLK 0x156 /* PHYAD2 */
>> + MX8MP_IOMUXC_ENET_RX_CTL__ENET_QOS_RGMII_RX_CTL 0x000 /* CLK125_EN */
>> + MX8MP_IOMUXC_GPIO1_IO00__CCM_ENET_PHY_REF_CLK_ROOT 0x110 /* LED_MODE */
>> + >;
>> + };
>> +
>> + pinctrl_eqos_sleep: eqos-sleep-grp {
>> + fsl,pins = <
>> + MX8MP_IOMUXC_SAI2_RXC__GPIO4_IO22 0x120
>> + MX8MP_IOMUXC_ENET_MDC__GPIO1_IO16 0x120
>> + MX8MP_IOMUXC_ENET_MDIO__GPIO1_IO17 0x120
>> + MX8MP_IOMUXC_ENET_TXC__GPIO1_IO23 0x120
>> + MX8MP_IOMUXC_ENET_TD0__GPIO1_IO21 0x120
>> + MX8MP_IOMUXC_ENET_TD1__GPIO1_IO20 0x120
>> + MX8MP_IOMUXC_ENET_TD2__GPIO1_IO19 0x120
>> + MX8MP_IOMUXC_ENET_TD3__GPIO1_IO18 0x120
>> + MX8MP_IOMUXC_ENET_TX_CTL__GPIO1_IO22 0x120
>> + MX8MP_IOMUXC_ENET_RD0__GPIO1_IO26 0x120
>> + MX8MP_IOMUXC_ENET_RD1__GPIO1_IO27 0x120
>> + MX8MP_IOMUXC_ENET_RD2__GPIO1_IO28 0x120
>> + MX8MP_IOMUXC_ENET_RD3__GPIO1_IO29 0x120
>> + MX8MP_IOMUXC_ENET_RXC__GPIO1_IO25 0x120
>> + MX8MP_IOMUXC_ENET_RX_CTL__GPIO1_IO24 0x120
>> + MX8MP_IOMUXC_GPIO1_IO00__GPIO1_IO00 0x120
>> + >;
>> + };
>> +};
>>
>
--
Pengutronix e.K. | Stefan Kerkmann |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-128 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
next prev parent reply other threads:[~2024-03-11 13:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 9:10 [PATCH 0/6] arm: imx8mp: add karo electronics qsxp imx8mp som support Stefan Kerkmann
2024-03-11 9:10 ` [PATCH 1/6] of: introduce of_property_read_s32 Stefan Kerkmann
2024-03-11 9:10 ` [PATCH 2/6] net: phy: micrel: update id table from Linux kernel Stefan Kerkmann
2024-03-11 9:10 ` [PATCH 3/6] net: phy: micrel: add support for ksz9131 phy Stefan Kerkmann
2024-03-11 9:10 ` [PATCH 4/6] arm: dts: karo: import dts for karo-qsxp-ml81 Stefan Kerkmann
2024-03-11 10:02 ` Ahmad Fatoum
2024-03-11 14:23 ` Stefan Kerkmann
2024-03-11 14:33 ` Ahmad Fatoum
2024-03-11 14:48 ` Stefan Kerkmann
2024-03-11 9:10 ` [PATCH 5/6] arm: dts: karo: add karo imx8mp-karo-qsxp-qsbase4 Stefan Kerkmann
2024-03-11 10:05 ` Ahmad Fatoum
2024-03-11 13:25 ` Stefan Kerkmann [this message]
2024-03-11 9:10 ` [PATCH 6/6] arm: imx8mp: add karo electronics qsxp imx8mp som support Stefan Kerkmann
2024-03-11 10:13 ` Ahmad Fatoum
2024-03-11 13:32 ` Stefan Kerkmann
2024-03-11 13:58 ` Ahmad Fatoum
2024-03-11 14:01 ` Stefan Kerkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdde2d67-547c-4d12-baac-0779351fda59@pengutronix.de \
--to=s.kerkmann@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox