From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Alexander Shiyan <eagle.alexander923@gmail.com>, Lucas Stach <l.stach@pengutronix.de> Cc: barebox@lists.infradead.org Subject: Re: [PATCH] ARM: OMAP: debug_ll: Use Kconfig UART base address Date: Thu, 5 May 2022 10:09:38 +0200 [thread overview] Message-ID: <fffb99c6-ba2d-3351-95be-e47f45167da6@pengutronix.de> (raw) In-Reply-To: <CAP1tNvRryE7UTtD2ejCLB5zt-uYVnW4qp2to7qDf+88cGG2Y0g@mail.gmail.com> On 05.05.22 10:01, Alexander Shiyan wrote: > чт, 5 мая 2022 г. в 10:55, Lucas Stach <l.stach@pengutronix.de>: >> Am Donnerstag, dem 05.05.2022 um 10:36 +0300 schrieb Alexander Shiyan: >>> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com> >> Is this really a change in the right direction? The way it is currently >> done seems to mix well with overall multi-image theme of Barebox. By >> using a Kconfig for that, the setting will most likely be wrong for a >> subset of boards in a multi-image build. > > Same as PUTC_LL, right? > > Actually the debug code is already wrong when we create multiple > images with different UARTs. There is pbl_set_putc(), which can be called after relocation for use by the PBL console and is multi-image friendly. > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-05-05 8:11 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-05 7:36 Alexander Shiyan 2022-05-05 7:55 ` Lucas Stach 2022-05-05 8:01 ` Alexander Shiyan 2022-05-05 8:09 ` Ahmad Fatoum [this message] 2022-05-05 8:13 ` Sascha Hauer 2022-05-05 9:42 ` Alexander Shiyan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fffb99c6-ba2d-3351-95be-e47f45167da6@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=eagle.alexander923@gmail.com \ --cc=l.stach@pengutronix.de \ --subject='Re: [PATCH] ARM: OMAP: debug_ll: Use Kconfig UART base address' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox