mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] video: simplefb-fixup: IORESOURCE_BUSY is deprecated use reserve_resource
@ 2026-04-09 12:10 Michael Grzeschik
  2026-04-09 12:15 ` Ahmad Fatoum
  2026-04-13  7:29 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Grzeschik @ 2026-04-09 12:10 UTC (permalink / raw)
  To: Sascha Hauer, BAREBOX; +Cc: Michael Grzeschik

Since the IORESOURCE_BUSY was retired, the simple-fixup driver was
missed to be changed. We fix this and also mark the driver memory as
reserved.

Fixes: 191b639dd53d ('resource: retire IORESOURCE_BUSY in favor of resource::type')
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
 drivers/video/simplefb-fixup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/simplefb-fixup.c b/drivers/video/simplefb-fixup.c
index e20f2922445bddcb13a049b2581c4c632289d6ee..94cf5a7884504a2dad80768ebedb413b171be868 100644
--- a/drivers/video/simplefb-fixup.c
+++ b/drivers/video/simplefb-fixup.c
@@ -124,8 +124,8 @@ static int simplefb_create_node(struct device_node *root,
 		return ret;
 
 	res.name = "simple-framebuffer";
-	res.flags |= IORESOURCE_BUSY;
 	resource_set_range(&res, screen_base, fbi->screen_size);
+	reserve_resource(&res);
 
 	of_fixup_reserved_memory(root, &res);
 

---
base-commit: 86269eff785a915cfb96f09d9c7ec81a89d33012
change-id: 20260409-simple-fixup-d519715f3e5f

Best regards,
-- 
Michael Grzeschik <m.grzeschik@pengutronix.de>




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] video: simplefb-fixup: IORESOURCE_BUSY is deprecated use reserve_resource
  2026-04-09 12:10 [PATCH] video: simplefb-fixup: IORESOURCE_BUSY is deprecated use reserve_resource Michael Grzeschik
@ 2026-04-09 12:15 ` Ahmad Fatoum
  2026-04-13  7:29 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2026-04-09 12:15 UTC (permalink / raw)
  To: Michael Grzeschik, Sascha Hauer, BAREBOX

On 4/9/26 2:10 PM, Michael Grzeschik wrote:
> Since the IORESOURCE_BUSY was retired, the simple-fixup driver was
> missed to be changed. We fix this and also mark the driver memory as
> reserved.
> 
> Fixes: 191b639dd53d ('resource: retire IORESOURCE_BUSY in favor of resource::type')
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  drivers/video/simplefb-fixup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/simplefb-fixup.c b/drivers/video/simplefb-fixup.c
> index e20f2922445bddcb13a049b2581c4c632289d6ee..94cf5a7884504a2dad80768ebedb413b171be868 100644
> --- a/drivers/video/simplefb-fixup.c
> +++ b/drivers/video/simplefb-fixup.c
> @@ -124,8 +124,8 @@ static int simplefb_create_node(struct device_node *root,
>  		return ret;
>  
>  	res.name = "simple-framebuffer";
> -	res.flags |= IORESOURCE_BUSY;
>  	resource_set_range(&res, screen_base, fbi->screen_size);
> +	reserve_resource(&res);
>  
>  	of_fixup_reserved_memory(root, &res);
>  
> 
> ---
> base-commit: 86269eff785a915cfb96f09d9c7ec81a89d33012
> change-id: 20260409-simple-fixup-d519715f3e5f
> 
> Best regards,

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] video: simplefb-fixup: IORESOURCE_BUSY is deprecated use reserve_resource
  2026-04-09 12:10 [PATCH] video: simplefb-fixup: IORESOURCE_BUSY is deprecated use reserve_resource Michael Grzeschik
  2026-04-09 12:15 ` Ahmad Fatoum
@ 2026-04-13  7:29 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2026-04-13  7:29 UTC (permalink / raw)
  To: BAREBOX, Michael Grzeschik


On Thu, 09 Apr 2026 14:10:18 +0200, Michael Grzeschik wrote:
> Since the IORESOURCE_BUSY was retired, the simple-fixup driver was
> missed to be changed. We fix this and also mark the driver memory as
> reserved.
> 
> 

Applied, thanks!

[1/1] video: simplefb-fixup: IORESOURCE_BUSY is deprecated use reserve_resource
      https://git.pengutronix.de/cgit/barebox/commit/?id=1069125230bc (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-13  7:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-09 12:10 [PATCH] video: simplefb-fixup: IORESOURCE_BUSY is deprecated use reserve_resource Michael Grzeschik
2026-04-09 12:15 ` Ahmad Fatoum
2026-04-13  7:29 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox