* [PATCH] mci: add missing break
@ 2026-04-15 8:13 Sascha Hauer
2026-04-17 9:08 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Sascha Hauer @ 2026-04-15 8:13 UTC (permalink / raw)
To: Barebox List
65077d2078 adds a new case to a switch/case which lacks a break, so it
falls through and EXT_CSD_REV = 0 is detected as MMC_VERSION_4_1 instead
of MMC_VERSION_4. Add the missing break.
Fixes: 65077d2078 ("mci: treat unknown MMC version as greater than known versions")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mci/mci-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index d3d7bd5e07..babb180ab1 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -1160,6 +1160,7 @@ static void mci_correct_version_from_ext_csd(struct mci *mci)
switch (mci->ext_csd[EXT_CSD_REV]) {
case 0:
mci->version = MMC_VERSION_4;
+ break;
case 1:
mci->version = MMC_VERSION_4_1;
break;
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mci: add missing break
2026-04-15 8:13 [PATCH] mci: add missing break Sascha Hauer
@ 2026-04-17 9:08 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2026-04-17 9:08 UTC (permalink / raw)
To: Barebox List, Sascha Hauer
On Wed, 15 Apr 2026 10:13:57 +0200, Sascha Hauer wrote:
> 65077d2078 adds a new case to a switch/case which lacks a break, so it
> falls through and EXT_CSD_REV = 0 is detected as MMC_VERSION_4_1 instead
> of MMC_VERSION_4. Add the missing break.
>
>
Applied, thanks!
[1/1] mci: add missing break
https://git.pengutronix.de/cgit/barebox/commit/?id=41295e7cd5e1 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-17 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-15 8:13 [PATCH] mci: add missing break Sascha Hauer
2026-04-17 9:08 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox