* [PATCH] MIPS: Makefile: minor codingstyle fix
@ 2019-11-22 8:34 Du Huanpeng
2019-11-22 9:08 ` Oleksij Rempel
0 siblings, 1 reply; 11+ messages in thread
From: Du Huanpeng @ 2019-11-22 8:34 UTC (permalink / raw)
To: barebox; +Cc: Du Huanpeng, Du Huanpeng
From: Du Huanpeng <u74147@gmail.com>
Signed-off-by: Du Huanpeng <duhuanpeng@loongson.cn>
---
arch/mips/Makefile | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index ee465dc..1c10db5 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -52,9 +52,7 @@ cflags-$(CONFIG_CPU_MIPS32_R1) += $(call cc-option,-march=mips32,-mips32 -U_MIPS
cflags-$(CONFIG_CPU_MIPS32_R2) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
cflags-$(CONFIG_CPU_MIPS64_R1) += $(call cc-option,-march=mips64,-mips64 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64 -Wa,--trap
cflags-$(CONFIG_CPU_MIPS64_R2) += $(call cc-option,-march=mips64r2,-mips64r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64r2 -Wa,--trap
-cflags-$(CONFIG_CPU_LOONGSON1) += \
- $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \
- -Wa,-mips32r2 -Wa,--trap
+cflags-$(CONFIG_CPU_LOONGSON1) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
CPPFLAGS += -DTEXT_BASE=$(CONFIG_TEXT_BASE)
--
2.7.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MIPS: Makefile: minor codingstyle fix
2019-11-22 8:34 [PATCH] MIPS: Makefile: minor codingstyle fix Du Huanpeng
@ 2019-11-22 9:08 ` Oleksij Rempel
2019-11-22 9:46 ` Tim Williams
0 siblings, 1 reply; 11+ messages in thread
From: Oleksij Rempel @ 2019-11-22 9:08 UTC (permalink / raw)
To: Du Huanpeng, barebox; +Cc: Du Huanpeng
Hi,
it is a bit more then just minor codingstyle fix. Can you please describe what was wrong and why the
change makes it better.
Am 22.11.19 um 09:34 schrieb Du Huanpeng:
> From: Du Huanpeng <u74147@gmail.com>
>
> Signed-off-by: Du Huanpeng <duhuanpeng@loongson.cn>
> ---
> arch/mips/Makefile | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index ee465dc..1c10db5 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -52,9 +52,7 @@ cflags-$(CONFIG_CPU_MIPS32_R1) += $(call cc-option,-march=mips32,-mips32 -U_MIPS
> cflags-$(CONFIG_CPU_MIPS32_R2) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
> cflags-$(CONFIG_CPU_MIPS64_R1) += $(call cc-option,-march=mips64,-mips64 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64 -Wa,--trap
> cflags-$(CONFIG_CPU_MIPS64_R2) += $(call cc-option,-march=mips64r2,-mips64r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64r2 -Wa,--trap
> -cflags-$(CONFIG_CPU_LOONGSON1) += \
> - $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \
> - -Wa,-mips32r2 -Wa,--trap
> +cflags-$(CONFIG_CPU_LOONGSON1) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
>
> CPPFLAGS += -DTEXT_BASE=$(CONFIG_TEXT_BASE)
>
>
--
Regards,
Oleksij
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MIPS: Makefile: minor codingstyle fix
2019-11-22 9:08 ` Oleksij Rempel
@ 2019-11-22 9:46 ` Tim Williams
2019-11-22 11:11 ` Oleksij Rempel
0 siblings, 1 reply; 11+ messages in thread
From: Tim Williams @ 2019-11-22 9:46 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: barebox
On Fri, Nov 22, 2019 at 10:08:55AM +0100, Oleksij Rempel wrote:
> Hi,
>
> it is a bit more then just minor codingstyle fix. Can you please describe what was wrong and why the
> change makes it better.
There is nothing wrong with it. :)
I am going to add one more after this line.I didn't know which codingstyle
to follow. so I send this patch to make this line's codingstyle the same
with previously lines.
Regards,
duhuanpeng
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MIPS: Makefile: minor codingstyle fix
2019-11-22 9:46 ` Tim Williams
@ 2019-11-22 11:11 ` Oleksij Rempel
2019-11-22 11:57 ` Du Huanpeng
0 siblings, 1 reply; 11+ messages in thread
From: Oleksij Rempel @ 2019-11-22 11:11 UTC (permalink / raw)
To: Tim Williams; +Cc: barebox
Am 22.11.19 um 10:46 schrieb Tim Williams:
> On Fri, Nov 22, 2019 at 10:08:55AM +0100, Oleksij Rempel wrote:
>> Hi,
>>
>> it is a bit more then just minor codingstyle fix. Can you please describe what was wrong and why the
>> change makes it better.
> There is nothing wrong with it. :)
> I am going to add one more after this line.I didn't know which codingstyle
> to follow. so I send this patch to make this line's codingstyle the same
> with previously lines.
Ah.. i see now.
Actually all of this lines haw incorrect coding style. It should be 80
char width style.
--
Regards,
Oleksij
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MIPS: Makefile: minor codingstyle fix
2019-11-22 11:11 ` Oleksij Rempel
@ 2019-11-22 11:57 ` Du Huanpeng
2019-11-25 8:40 ` Sascha Hauer
0 siblings, 1 reply; 11+ messages in thread
From: Du Huanpeng @ 2019-11-22 11:57 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: barebox
Hi.
> Actually all of this lines haw incorrect coding style. It should be 80
> char width style.
I see this, but it is more practical here. the editor will automatic warp lines.
I can write a better description and send a v2 patch.
Regards,
Du Huanpeng
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MIPS: Makefile: minor codingstyle fix
2019-11-22 11:57 ` Du Huanpeng
@ 2019-11-25 8:40 ` Sascha Hauer
0 siblings, 0 replies; 11+ messages in thread
From: Sascha Hauer @ 2019-11-25 8:40 UTC (permalink / raw)
To: Du Huanpeng; +Cc: barebox, Oleksij Rempel
On Fri, Nov 22, 2019 at 07:57:03PM +0800, Du Huanpeng wrote:
> Hi.
>
> > Actually all of this lines haw incorrect coding style. It should be 80
> > char width style.
> I see this, but it is more practical here. the editor will automatic warp lines.
>
> I can write a better description and send a v2 patch.
Please do so. Please don't take 80 chars as a hard limit. While I think
the lines we are talking about here are a bit long, forcing it to 80
chars doesn't really improve readability.
i.e the following looks good, eventhough it's longer than 80 chars:
cflags-$(CONFIG_CPU_LOONGSON1) += \
$(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \
-Wa,-mips32r2 -Wa,--trap
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MIPS: Makefile: minor codingstyle fix
2019-11-27 1:07 Du Huanpeng
2019-11-27 5:22 ` Oleksij Rempel
@ 2019-11-27 14:02 ` Sascha Hauer
1 sibling, 0 replies; 11+ messages in thread
From: Sascha Hauer @ 2019-11-27 14:02 UTC (permalink / raw)
To: Du Huanpeng; +Cc: barebox
On Wed, Nov 27, 2019 at 09:07:51AM +0800, Du Huanpeng wrote:
> it exceeds 80 chararacters per line, but is more readable and
> agrees agrees with the previous lines.
>
> Signed-off-by: Du Huanpeng <duhuanpeng@loongson.cn>
> ---
> arch/mips/Makefile | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MIPS: Makefile: minor codingstyle fix
2019-11-27 5:22 ` Oleksij Rempel
@ 2019-11-27 5:58 ` Du Huanpeng
0 siblings, 0 replies; 11+ messages in thread
From: Du Huanpeng @ 2019-11-27 5:58 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: barebox
> The version can be added automatically by creating the mail with:
> git format-patch -v3
Ah, thank you very much.
Regards,
duhuanpeng
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] MIPS: Makefile: minor codingstyle fix
2019-11-27 1:07 Du Huanpeng
@ 2019-11-27 5:22 ` Oleksij Rempel
2019-11-27 5:58 ` Du Huanpeng
2019-11-27 14:02 ` Sascha Hauer
1 sibling, 1 reply; 11+ messages in thread
From: Oleksij Rempel @ 2019-11-27 5:22 UTC (permalink / raw)
To: Du Huanpeng, barebox
Hi,
please, if you send new version of some patch, add version number to it. It should look like this:
[PATCH v3] MIPS: Makefile: minor codingstyle fix
The version can be added automatically by creating the mail with:
git format-patch -v3
Am 27.11.19 um 02:07 schrieb Du Huanpeng:
> it exceeds 80 chararacters per line, but is more readable and
> agrees agrees with the previous lines.
>
> Signed-off-by: Du Huanpeng <duhuanpeng@loongson.cn>
> ---
> arch/mips/Makefile | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index ee465dc..1c10db5 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -52,9 +52,7 @@ cflags-$(CONFIG_CPU_MIPS32_R1) += $(call cc-option,-march=mips32,-mips32 -U_MIPS
> cflags-$(CONFIG_CPU_MIPS32_R2) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
> cflags-$(CONFIG_CPU_MIPS64_R1) += $(call cc-option,-march=mips64,-mips64 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64 -Wa,--trap
> cflags-$(CONFIG_CPU_MIPS64_R2) += $(call cc-option,-march=mips64r2,-mips64r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64r2 -Wa,--trap
> -cflags-$(CONFIG_CPU_LOONGSON1) += \
> - $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \
> - -Wa,-mips32r2 -Wa,--trap
> +cflags-$(CONFIG_CPU_LOONGSON1) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
>
> CPPFLAGS += -DTEXT_BASE=$(CONFIG_TEXT_BASE)
>
>
--
Regards,
Oleksij
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] MIPS: Makefile: minor codingstyle fix
@ 2019-11-27 1:07 Du Huanpeng
2019-11-27 5:22 ` Oleksij Rempel
2019-11-27 14:02 ` Sascha Hauer
0 siblings, 2 replies; 11+ messages in thread
From: Du Huanpeng @ 2019-11-27 1:07 UTC (permalink / raw)
To: barebox; +Cc: Du Huanpeng
it exceeds 80 chararacters per line, but is more readable and
agrees agrees with the previous lines.
Signed-off-by: Du Huanpeng <duhuanpeng@loongson.cn>
---
arch/mips/Makefile | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index ee465dc..1c10db5 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -52,9 +52,7 @@ cflags-$(CONFIG_CPU_MIPS32_R1) += $(call cc-option,-march=mips32,-mips32 -U_MIPS
cflags-$(CONFIG_CPU_MIPS32_R2) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
cflags-$(CONFIG_CPU_MIPS64_R1) += $(call cc-option,-march=mips64,-mips64 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64 -Wa,--trap
cflags-$(CONFIG_CPU_MIPS64_R2) += $(call cc-option,-march=mips64r2,-mips64r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64r2 -Wa,--trap
-cflags-$(CONFIG_CPU_LOONGSON1) += \
- $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \
- -Wa,-mips32r2 -Wa,--trap
+cflags-$(CONFIG_CPU_LOONGSON1) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
CPPFLAGS += -DTEXT_BASE=$(CONFIG_TEXT_BASE)
--
2.7.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] MIPS: Makefile: minor codingstyle fix
@ 2019-11-26 7:12 Du Huanpeng
0 siblings, 0 replies; 11+ messages in thread
From: Du Huanpeng @ 2019-11-26 7:12 UTC (permalink / raw)
To: barebox; +Cc: Du Huanpeng
exceed 80 characters in a line, but more readble and agree with
upper lines.
Signed-off-by: Du Huanpeng <duhuanpeng@loongson.cn>
---
arch/mips/Makefile | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index ee465dc..1c10db5 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -52,9 +52,7 @@ cflags-$(CONFIG_CPU_MIPS32_R1) += $(call cc-option,-march=mips32,-mips32 -U_MIPS
cflags-$(CONFIG_CPU_MIPS32_R2) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
cflags-$(CONFIG_CPU_MIPS64_R1) += $(call cc-option,-march=mips64,-mips64 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64 -Wa,--trap
cflags-$(CONFIG_CPU_MIPS64_R2) += $(call cc-option,-march=mips64r2,-mips64r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64r2 -Wa,--trap
-cflags-$(CONFIG_CPU_LOONGSON1) += \
- $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \
- -Wa,-mips32r2 -Wa,--trap
+cflags-$(CONFIG_CPU_LOONGSON1) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
CPPFLAGS += -DTEXT_BASE=$(CONFIG_TEXT_BASE)
--
2.7.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-11-27 14:02 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 8:34 [PATCH] MIPS: Makefile: minor codingstyle fix Du Huanpeng
2019-11-22 9:08 ` Oleksij Rempel
2019-11-22 9:46 ` Tim Williams
2019-11-22 11:11 ` Oleksij Rempel
2019-11-22 11:57 ` Du Huanpeng
2019-11-25 8:40 ` Sascha Hauer
2019-11-26 7:12 Du Huanpeng
2019-11-27 1:07 Du Huanpeng
2019-11-27 5:22 ` Oleksij Rempel
2019-11-27 5:58 ` Du Huanpeng
2019-11-27 14:02 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox