mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] nvmem: ocotp: fix fusing on fsl, imx6q-ocotp compatible boards
@ 2020-11-12 10:00 Robin van der Gracht
  2020-11-12 10:05 ` [PATCH] nvmem: ocotp: fix fusing on fsl,imx6q-ocotp " Rouven Czerwinski
  2020-11-12 11:12 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Robin van der Gracht @ 2020-11-12 10:00 UTC (permalink / raw)
  To: barebox; +Cc: Oleksij Rempel, Rouven Czerwinski, Robin van der Gracht

The imx6q_ocotp_data struct is incomplete resulting in a crash when trying
to read/blow fuses.

Signed-off-by: Robin van der Gracht <robin@protonic.nl>
---
 drivers/nvmem/ocotp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvmem/ocotp.c b/drivers/nvmem/ocotp.c
index 356e9bf11..cee50955e 100644
--- a/drivers/nvmem/ocotp.c
+++ b/drivers/nvmem/ocotp.c
@@ -833,6 +833,8 @@ static struct imx_ocotp_data imx6q_ocotp_data = {
 	.mac_offsets = { MAC_OFFSET_0 },
 	.format_mac = imx_ocotp_format_mac,
 	.set_timing = imx6_ocotp_set_timing,
+	.fuse_blow = imx6_fuse_blow_addr,
+	.fuse_read = imx6_fuse_read_addr,
 };
 
 static struct imx_ocotp_data imx6sl_ocotp_data = {
-- 
2.25.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] nvmem: ocotp: fix fusing on fsl,imx6q-ocotp compatible boards
  2020-11-12 10:00 [PATCH] nvmem: ocotp: fix fusing on fsl, imx6q-ocotp compatible boards Robin van der Gracht
@ 2020-11-12 10:05 ` Rouven Czerwinski
  2020-11-12 11:12 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Rouven Czerwinski @ 2020-11-12 10:05 UTC (permalink / raw)
  To: Robin van der Gracht, barebox; +Cc: Oleksij Rempel

On Thu, 2020-11-12 at 11:00 +0100, Robin van der Gracht wrote:
> The imx6q_ocotp_data struct is incomplete resulting in a crash when
> trying
> to read/blow fuses.
> 
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
>  drivers/nvmem/ocotp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/nvmem/ocotp.c b/drivers/nvmem/ocotp.c
> index 356e9bf11..cee50955e 100644
> --- a/drivers/nvmem/ocotp.c
> +++ b/drivers/nvmem/ocotp.c
> @@ -833,6 +833,8 @@ static struct imx_ocotp_data imx6q_ocotp_data = {
>  	.mac_offsets = { MAC_OFFSET_0 },
>  	.format_mac = imx_ocotp_format_mac,
>  	.set_timing = imx6_ocotp_set_timing,
> +	.fuse_blow = imx6_fuse_blow_addr,
> +	.fuse_read = imx6_fuse_read_addr,
>  };
>  
>  static struct imx_ocotp_data imx6sl_ocotp_data = {

Fixes: 17cba91885d9 ("nvmem: ocotp: read/write i.MX7 support")

Reviewed-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

Thanks for the fix,
Rouven


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] nvmem: ocotp: fix fusing on fsl,imx6q-ocotp compatible boards
  2020-11-12 10:00 [PATCH] nvmem: ocotp: fix fusing on fsl, imx6q-ocotp compatible boards Robin van der Gracht
  2020-11-12 10:05 ` [PATCH] nvmem: ocotp: fix fusing on fsl,imx6q-ocotp " Rouven Czerwinski
@ 2020-11-12 11:12 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2020-11-12 11:12 UTC (permalink / raw)
  To: Robin van der Gracht; +Cc: barebox, Rouven Czerwinski, Oleksij Rempel

On Thu, Nov 12, 2020 at 11:00:42AM +0100, Robin van der Gracht wrote:
> The imx6q_ocotp_data struct is incomplete resulting in a crash when trying
> to read/blow fuses.
> 
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
>  drivers/nvmem/ocotp.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/nvmem/ocotp.c b/drivers/nvmem/ocotp.c
> index 356e9bf11..cee50955e 100644
> --- a/drivers/nvmem/ocotp.c
> +++ b/drivers/nvmem/ocotp.c
> @@ -833,6 +833,8 @@ static struct imx_ocotp_data imx6q_ocotp_data = {
>  	.mac_offsets = { MAC_OFFSET_0 },
>  	.format_mac = imx_ocotp_format_mac,
>  	.set_timing = imx6_ocotp_set_timing,
> +	.fuse_blow = imx6_fuse_blow_addr,
> +	.fuse_read = imx6_fuse_read_addr,
>  };
>  
>  static struct imx_ocotp_data imx6sl_ocotp_data = {
> -- 
> 2.25.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-12 11:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 10:00 [PATCH] nvmem: ocotp: fix fusing on fsl, imx6q-ocotp compatible boards Robin van der Gracht
2020-11-12 10:05 ` [PATCH] nvmem: ocotp: fix fusing on fsl,imx6q-ocotp " Rouven Czerwinski
2020-11-12 11:12 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox