[PATCH] debug_ll: ns16550: Fix interrupt disable on init

[PATCH] debug_ll: ns16550: Fix interrupt disable on init

[Jules Maselbas]

The debug_ll_write_reg function takes first the register
and secondly the value to write, which in this call were
inverted. Fix the argument order.

Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
---
 include/debug_ll/ns16550.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/debug_ll/ns16550.h b/include/debug_ll/ns16550.h
index 7e4dbeb453..373c917d86 100644
--- a/include/debug_ll/ns16550.h
+++ b/include/debug_ll/ns16550.h
@@ -43,7 +43,7 @@ static inline uint16_t debug_ll_ns16550_calc_divisor(unsigned long clk)
 static inline void debug_ll_ns16550_init(uint16_t divisor)
 {
 	debug_ll_write_reg(NS16550_LCR, 0x0); /* select ier reg */
-        debug_ll_write_reg(0x00, NS16550_IER);
+	debug_ll_write_reg(NS16550_IER, 0x0); /* disable interrupts */
 
 	debug_ll_write_reg(NS16550_LCR, NS16550_LCR_BKSE);
 	debug_ll_write_reg(NS16550_DLL, divisor & 0xff);
-- 
2.17.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] debug_ll: ns16550: Fix interrupt disable on init

[Jules Maselbas]

ping

On Mon, Oct 04, 2021 at 09:38:42AM +0200, Jules Maselbas wrote:
> The debug_ll_write_reg function takes first the register
> and secondly the value to write, which in this call were
> inverted. Fix the argument order.
> 
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> ---
>  include/debug_ll/ns16550.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/debug_ll/ns16550.h b/include/debug_ll/ns16550.h
> index 7e4dbeb453..373c917d86 100644
> --- a/include/debug_ll/ns16550.h
> +++ b/include/debug_ll/ns16550.h
> @@ -43,7 +43,7 @@ static inline uint16_t debug_ll_ns16550_calc_divisor(unsigned long clk)
>  static inline void debug_ll_ns16550_init(uint16_t divisor)
>  {
>  	debug_ll_write_reg(NS16550_LCR, 0x0); /* select ier reg */
> -        debug_ll_write_reg(0x00, NS16550_IER);
> +	debug_ll_write_reg(NS16550_IER, 0x0); /* disable interrupts */
>  
>  	debug_ll_write_reg(NS16550_LCR, NS16550_LCR_BKSE);
>  	debug_ll_write_reg(NS16550_DLL, divisor & 0xff);
> -- 
> 2.17.1
> 





_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] debug_ll: ns16550: Fix interrupt disable on init

[Sascha Hauer]

On Mon, Oct 04, 2021 at 09:38:42AM +0200, Jules Maselbas wrote:
> The debug_ll_write_reg function takes first the register
> and secondly the value to write, which in this call were
> inverted. Fix the argument order.
> 
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> ---
>  include/debug_ll/ns16550.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] debug_ll: ns16550: Fix interrupt disable on init

[Sascha Hauer]

On Thu, Nov 18, 2021 at 01:33:57PM +0100, Jules Maselbas wrote:
> ping

Sorry, I misconfigured my .procmailrc when you sent this patch, so I
lost it.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox