[PATCH] clk: bulk: improve error message on failure to get

[PATCH] clk: bulk: improve error message on failure to get

[Ahmad Fatoum]

We didn't have the need to handle %pOF specially yet, but for the error
message in clk-bulk, not readily knowing what component couldn't get its
clocks is annoying. Print the node name directly and change the error
code to the error string if those are compiled in.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/clk/clk-bulk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c
index d530b4f968e6..4510283962ae 100644
--- a/drivers/clk/clk-bulk.c
+++ b/drivers/clk/clk-bulk.c
@@ -88,8 +88,8 @@ static int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
 		clks[i].clk = of_clk_get(np, i);
 		if (IS_ERR(clks[i].clk)) {
 			ret = PTR_ERR(clks[i].clk);
-			pr_err("%pOF: Failed to get clk index: %d ret: %d\n",
-				np, i, ret);
+			pr_err("%s: Failed to get clk index: %d ret: %pe\n",
+				np->name, i, clks[i].clk);
 			clks[i].clk = NULL;
 			goto err;
 		}
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] clk: bulk: improve error message on failure to get

[Sascha Hauer]

On Thu, Dec 02, 2021 at 08:42:24AM +0100, Ahmad Fatoum wrote:
> We didn't have the need to handle %pOF specially yet, but for the error
> message in clk-bulk, not readily knowing what component couldn't get its
> clocks is annoying. Print the node name directly and change the error
> code to the error string if those are compiled in.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/clk/clk-bulk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c
> index d530b4f968e6..4510283962ae 100644
> --- a/drivers/clk/clk-bulk.c
> +++ b/drivers/clk/clk-bulk.c
> @@ -88,8 +88,8 @@ static int __must_check of_clk_bulk_get(struct device_node *np, int num_clks,
>  		clks[i].clk = of_clk_get(np, i);
>  		if (IS_ERR(clks[i].clk)) {
>  			ret = PTR_ERR(clks[i].clk);
> -			pr_err("%pOF: Failed to get clk index: %d ret: %d\n",
> -				np, i, ret);
> +			pr_err("%s: Failed to get clk index: %d ret: %pe\n",
> +				np->name, i, clks[i].clk);
>  			clks[i].clk = NULL;
>  			goto err;
>  		}
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox