mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] x86: <asm/io.h>: fix outl/outsl access size
@ 2022-01-07  6:36 Ahmad Fatoum
  2022-01-10  8:18 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2022-01-07  6:36 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

outl so far behaved like outb, probably due to a copy-paste error when
it was first added. We have three users in-tree for outl:

* drivers/serial/serial_ns16550_pci.c
  only for handling a Quatech qurik, which probably no one ever needed

* drivers/serial/serial_ns16550.c
  For platform drivers with a 4 byte I/O port resource. Only possible
  user is x86 and that has a 1 byte I/O port resource. Thus no one
  used this either.

* drivers/watchdog/itco_wdt.c
  Here it indeed triggers a bug, although in my testing the WDAT
  was functional without.

Fix this up so new code doesn't have to track this down.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Cc: Steffen Trumtrar <str@pengutronix.de>
---
 arch/x86/include/asm/io.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
index 0971727bc63d..23854128cb06 100644
--- a/arch/x86/include/asm/io.h
+++ b/arch/x86/include/asm/io.h
@@ -63,13 +63,13 @@ BUILDIO(l, , int)
 
 #define outb	outb
 #define outw	outw
-#define outl	outb
+#define outl	outl
 #define inb	inb
 #define inw	inw
 #define inl	inl
 #define outsb	outsb
 #define outsw	outsw
-#define outsl	outsb
+#define outsl	outsl
 #define insb	insb
 #define insw	insw
 #define insl	insl
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] x86: <asm/io.h>: fix outl/outsl access size
  2022-01-07  6:36 [PATCH master] x86: <asm/io.h>: fix outl/outsl access size Ahmad Fatoum
@ 2022-01-10  8:18 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-01-10  8:18 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Fri, Jan 07, 2022 at 07:36:44AM +0100, Ahmad Fatoum wrote:
> outl so far behaved like outb, probably due to a copy-paste error when
> it was first added. We have three users in-tree for outl:
> 
> * drivers/serial/serial_ns16550_pci.c
>   only for handling a Quatech qurik, which probably no one ever needed
> 
> * drivers/serial/serial_ns16550.c
>   For platform drivers with a 4 byte I/O port resource. Only possible
>   user is x86 and that has a 1 byte I/O port resource. Thus no one
>   used this either.
> 
> * drivers/watchdog/itco_wdt.c
>   Here it indeed triggers a bug, although in my testing the WDAT
>   was functional without.
> 
> Fix this up so new code doesn't have to track this down.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> Cc: Steffen Trumtrar <str@pengutronix.de>
> ---
>  arch/x86/include/asm/io.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-10  8:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-07  6:36 [PATCH master] x86: <asm/io.h>: fix outl/outsl access size Ahmad Fatoum
2022-01-10  8:18 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git