mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem
@ 2022-03-29  7:33 Andrej Picej
  2022-03-29  7:33 ` [PATCH v2 2/2] ARM: boards: phytec-som-imx6: probe all gpio devices before PMIC Andrej Picej
  2022-03-29  8:56 ` [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem Sascha Hauer
  0 siblings, 2 replies; 4+ messages in thread
From: Andrej Picej @ 2022-03-29  7:33 UTC (permalink / raw)
  To: barebox; +Cc: upstream

Function first goes through all the aliases which have the given stem.
It then ensures that all the devices hiding under these aliases are
probed.

User can specify one device_node which won't get probed. This is mainly
for avoiding recursion if the function will be called from device probe
function, or to specify the device which should get probed last. In the
later case the user should probe the last device manually.

Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
Changes in v2:
 - add check for deep probe support,
 - users can now specify one device node, which won't get probed. This
   ensures that one device can be probed last and we avoid recursion, if
this device happens to have alias,
 - fix function name (ensured -> ensure).
---
 drivers/of/base.c | 40 ++++++++++++++++++++++++++++++++++++++++
 include/of.h      |  6 ++++++
 2 files changed, 46 insertions(+)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 80465d6d50..ad747e9e63 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -274,6 +274,46 @@ int of_alias_get_id_from(struct device_node *root, struct device_node *np,
 }
 EXPORT_SYMBOL_GPL(of_alias_get_id_from);
 
+/**
+ * of_device_ensured_probed_by_alias_stem - Ensure all devices with alias base name
+ * are probed
+ * @np:		Device node of a device that should be probed last, NULL if such
+ * 		device doesn't exist
+ * @stem:	Alias stem of the given device_node
+ *
+ * The function ensures all devices with the given alias stem are probed before the
+ * target device.
+ *
+ * Returns 0 on success or error code.
+ */
+int of_device_ensure_probed_by_alias_stem(struct device_node *np, const char *stem)
+{
+	struct alias_prop *app;
+	int id = -ENODEV;
+	int ret;
+
+	if (!deep_probe_is_supported())
+		return 0;
+
+	list_for_each_entry(app, &aliases_lookup, link) {
+		if (of_node_cmp(app->stem, stem) != 0)
+			continue;
+
+		/* If device node is given skip the probing of that device so we
+		 * avoid recursion.
+		 */
+		if (np != NULL && np == app->np)
+			continue;
+
+		ret = of_device_ensure_probed(app->np);
+		if (ret)
+			return ret;
+	}
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(of_device_ensure_probed_by_alias_stem);
+
 const char *of_alias_get(struct device_node *np)
 {
 	struct alias_prop *app;
diff --git a/include/of.h b/include/of.h
index 216d0ee763..0b520bb35c 100644
--- a/include/of.h
+++ b/include/of.h
@@ -261,6 +261,7 @@ extern void of_alias_scan(void);
 extern int of_alias_get_id(struct device_node *np, const char *stem);
 extern int of_alias_get_id_from(struct device_node *root, struct device_node *np,
 				const char *stem);
+extern int of_device_ensure_probed_by_alias_stem(struct device_node *np, const char *stem);
 extern const char *of_alias_get(struct device_node *np);
 extern int of_modalias_node(struct device_node *node, char *modalias, int len);
 
@@ -750,6 +751,11 @@ static inline int of_alias_get_id_from(struct device_node *root, struct device_n
 	return -ENOSYS;
 }
 
+static int of_device_ensure_probed_by_alias_stem(struct device_node *np, const char *stem)
+{
+	return -ENOSYS;
+}
+
 static inline const char *of_alias_get(struct device_node *np)
 {
 	return NULL;
-- 
2.25.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] ARM: boards: phytec-som-imx6: probe all gpio devices before PMIC
  2022-03-29  7:33 [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem Andrej Picej
@ 2022-03-29  7:33 ` Andrej Picej
  2022-03-29  8:56 ` [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem Sascha Hauer
  1 sibling, 0 replies; 4+ messages in thread
From: Andrej Picej @ 2022-03-29  7:33 UTC (permalink / raw)
  To: barebox; +Cc: upstream

GPIO lines in da9063 are assigned dynamically, while majority of SOC
GPIO drivers assign their GPIOs in static manner (GPIO line numbers can
be calculated).

This introduces regression if deep probe support is used. If da9063
GPIOs are registered before the SOCs GPIOs, there is a good chance that
the SOCs statically computed GPIO line numbers will already be used by
PMIC.

Ensure all SOCs GPIO drivers and GPIO lines get registered before the
da9063 registers its own gpiochip.

Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
Changes in v2:
- move function from da9062 probe to board file
---
 arch/arm/boards/phytec-som-imx6/board.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
index 1e515a093a..5dc7f676ed 100644
--- a/arch/arm/boards/phytec-som-imx6/board.c
+++ b/arch/arm/boards/phytec-som-imx6/board.c
@@ -111,6 +111,10 @@ static int phycore_da9062_setup_buck_mode(void)
 	if (!pmic_np)
 		return -ENODEV;
 
+	ret = of_device_ensure_probed_by_alias_stem(pmic_np, "gpio");
+	if (ret)
+		return ret;
+
 	ret = of_device_ensure_probed(pmic_np);
 	if (ret)
 		return ret;
-- 
2.25.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem
  2022-03-29  7:33 [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem Andrej Picej
  2022-03-29  7:33 ` [PATCH v2 2/2] ARM: boards: phytec-som-imx6: probe all gpio devices before PMIC Andrej Picej
@ 2022-03-29  8:56 ` Sascha Hauer
  2022-03-29 10:43   ` Andrej Picej
  1 sibling, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2022-03-29  8:56 UTC (permalink / raw)
  To: Andrej Picej; +Cc: barebox, upstream

Hi Andrej,

On Tue, Mar 29, 2022 at 09:33:32AM +0200, Andrej Picej wrote:
> Function first goes through all the aliases which have the given stem.
> It then ensures that all the devices hiding under these aliases are
> probed.
> 
> User can specify one device_node which won't get probed. This is mainly
> for avoiding recursion if the function will be called from device probe
> function, or to specify the device which should get probed last. In the
> later case the user should probe the last device manually.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
> Changes in v2:
>  - add check for deep probe support,
>  - users can now specify one device node, which won't get probed. This
>    ensures that one device can be probed last and we avoid recursion, if
> this device happens to have alias,
>  - fix function name (ensured -> ensure).

Your v2 came before I had a chance to react to your comments on v1, I
was on vacation last week. I looked at the issue from another
perspective and rather than ensuring a certain probe order I think we
should decouple the GPIO numbers (at least the ones from the SoC
internal controllers) from the probe order, see the patch I just sent.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem
  2022-03-29  8:56 ` [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem Sascha Hauer
@ 2022-03-29 10:43   ` Andrej Picej
  0 siblings, 0 replies; 4+ messages in thread
From: Andrej Picej @ 2022-03-29 10:43 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox, upstream

Hi Sascha,

On 29. 03. 22 10:56, Sascha Hauer wrote:
> Hi Andrej,
> 
> On Tue, Mar 29, 2022 at 09:33:32AM +0200, Andrej Picej wrote:
>> Function first goes through all the aliases which have the given stem.
>> It then ensures that all the devices hiding under these aliases are
>> probed.
>>
>> User can specify one device_node which won't get probed. This is mainly
>> for avoiding recursion if the function will be called from device probe
>> function, or to specify the device which should get probed last. In the
>> later case the user should probe the last device manually.
>>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>> ---
>> Changes in v2:
>>   - add check for deep probe support,
>>   - users can now specify one device node, which won't get probed. This
>>     ensures that one device can be probed last and we avoid recursion, if
>> this device happens to have alias,
>>   - fix function name (ensured -> ensure).
> 
> Your v2 came before I had a chance to react to your comments on v1, I
> was on vacation last week. I looked at the issue from another
> perspective and rather than ensuring a certain probe order I think we
> should decouple the GPIO numbers (at least the ones from the SoC
> internal controllers) from the probe order, see the patch I just sent.

Sorry didn't mean to push you. Just figured out that it would be easier 
to talk about this topic when we have v2 version :).

OK, the patch looks good. As you said, solution from different 
perspective. Will test it out and get back to you with results.

Thanks for your help/work.

Andrej

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-03-29 10:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-29  7:33 [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem Andrej Picej
2022-03-29  7:33 ` [PATCH v2 2/2] ARM: boards: phytec-som-imx6: probe all gpio devices before PMIC Andrej Picej
2022-03-29  8:56 ` [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem Sascha Hauer
2022-03-29 10:43   ` Andrej Picej

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox