* [PATCH] common: ubiformat: print 100 % complete message when done
@ 2022-10-05 19:57 Ahmad Fatoum
2022-10-07 8:30 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2022-10-05 19:57 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
During formatting, current progress is printed every 300ms, e.g.:
ubiformat: formatting eraseblock 1936 -- 95 % complete
When formatting is done, a single new line is printed. When ubiformat is
called in the fastboot workqueue, the barebox prompt won't be printed
again, so the user may think that update is stuck at the last message
printed. Improve user experience by explicitly printing a 100 % complete
message.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/ubiformat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/ubiformat.c b/common/ubiformat.c
index e10ce31ce659..1edfc5b2a3b9 100644
--- a/common/ubiformat.c
+++ b/common/ubiformat.c
@@ -444,7 +444,7 @@ static int format(struct ubiformat_args *args, struct mtd_info *mtd,
}
if (!args->quiet && !args->verbose)
- printf("\n");
+ printf("\rubiformat: formatted all eraseblocks -- 100 %% complete\n");
if (!novtbl) {
if (eb1 == -1 || eb2 == -1) {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] common: ubiformat: print 100 % complete message when done
2022-10-05 19:57 [PATCH] common: ubiformat: print 100 % complete message when done Ahmad Fatoum
@ 2022-10-07 8:30 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-10-07 8:30 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Wed, Oct 05, 2022 at 09:57:30PM +0200, Ahmad Fatoum wrote:
> During formatting, current progress is printed every 300ms, e.g.:
>
> ubiformat: formatting eraseblock 1936 -- 95 % complete
>
> When formatting is done, a single new line is printed. When ubiformat is
> called in the fastboot workqueue, the barebox prompt won't be printed
> again, so the user may think that update is stuck at the last message
> printed. Improve user experience by explicitly printing a 100 % complete
> message.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> common/ubiformat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/common/ubiformat.c b/common/ubiformat.c
> index e10ce31ce659..1edfc5b2a3b9 100644
> --- a/common/ubiformat.c
> +++ b/common/ubiformat.c
> @@ -444,7 +444,7 @@ static int format(struct ubiformat_args *args, struct mtd_info *mtd,
> }
>
> if (!args->quiet && !args->verbose)
> - printf("\n");
> + printf("\rubiformat: formatted all eraseblocks -- 100 %% complete\n");
>
> if (!novtbl) {
> if (eb1 == -1 || eb2 == -1) {
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-07 8:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-05 19:57 [PATCH] common: ubiformat: print 100 % complete message when done Ahmad Fatoum
2022-10-07 8:30 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox