Re: [PATCH 00/11] ARM: at91: sama5d4: add basic Wifx L1 support

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Sam,

On 27.12.22 11:26, Sam Ravnborg wrote:
> Hi Ahmad,
> 
> On Wed, Dec 14, 2022 at 11:58:20AM +0100, Ahmad Fatoum wrote:
>> The Wifx L1 is a SAMA5D4 LoRaWAN gateway. It boots from NAND, but this
>> can be overridden by inserting a bootable SD-Card.
>>
>> This first port only provides second-stage SD-Card support.
> Nice.
> 
> I browsed the individual patches - they all looked good.

Thanks for the review. I have also resynced the Atmel NAND driver with
Linux to get support for the new EBI binding, but I'll send that out
as a separate patch once this is in. (If you need it for your hacking,
I can push it somewhere before that though).

> The DT file in patch 11 looks like a file that would be a good linux
> kernel candidate - but I guess this is for someone else to do.

It's on the bucket list, but first barebox, DistroKit and then eventually
upstreaming the kernel DT.

> Full series are:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

Thanks! I will add it onto v2.

> I look forward to the day where the remaining three sama5d boards are all
> multi-board and DT-enabled. This patch-set brings us a step closer.

I don't have the boards, that are not yet DT-enabled, but I guess due
diligence is done if we verify that the DT-enabled drivers work on some
other SAMA5 board, which already has DT support. Now, with the NAND
driver I ported for this, there remain three drivers that I have so
far not tested:

LCD, PWM and USB (Both Host/Gadget).

If you tell me, that all these already work just fine for some SAMA5 with
DT (or that they didn't work at all for SAMA5 without DT), I can send the
patch series switching the remaining boards to multi-image.

> Do you know if there is a way to read bootsource from an at91sam92XX
> CPU / ROMBOOT code?

I just observed that the info is in r4 on all SAMA5 SoCs. Maybe that's
the case for the older SoCs too? 

> There as nothing mentioned in the datasheet I looked at.

That seems to be the case everywhere. Registers read/written by ROM code
are seldom documented.

> As I have fired up my at91sam9263 board for the Xmas holidays I may
> try to play around with it a bit, but for now I have only SD-card boot working.

I am doing some holiday hacking too, but on a Rockchip RK3399. :)

Cheers,
Ahmad

> 
> 	Sam
> 
> 
> It enables
>> use of UART, I2C/EEPROM, Ethernet and SD-Card. For NAND use on SAMA5D4,
>> an updated Linux driver was ported to barebox.
>> This will follow separately.
>>
>> Ahmad Fatoum (11):
>>   ARM: at91: sama5: switch to nonnaked entry functions
>>   ARM: at91: sama5d4: add entry point helpers
>>   ARM: at91: sama5d4: enable for DT use
>>   net: macb: match atmel,sama5d4-gem compatible
>>   i2c: at91: extend for SAMA5D4 support
>>   eeprom: at24: add 24mac402/602 support
>>   driver: always ensure probe of RAM registered with mem_platform_driver
>>   common: deep-probe: don't build without CONFIG_OFDEVICE
>>   pinctrl: at91: make deep-probe compatible
>>   ARM: at91: make bootsource code generic to all SAMA5
>>   ARM: at91: SAMA5D4: add Wifx L1 support
>>
>>  arch/arm/boards/Makefile                      |   1 +
>>  .../boards/microchip-ksz9477-evb/lowlevel.c   |   6 +-
>>  .../arm/boards/sama5d27-giantboard/lowlevel.c |   4 +-
>>  arch/arm/boards/sama5d27-som1/lowlevel.c      |   4 +-
>>  arch/arm/boards/sama5d3_xplained/lowlevel.c   |   6 +-
>>  arch/arm/boards/sama5d4_wifx/Makefile         |   4 +
>>  arch/arm/boards/sama5d4_wifx/board.c          |  38 ++
>>  arch/arm/boards/sama5d4_wifx/lowlevel.c       |  18 +
>>  arch/arm/dts/Makefile                         |   1 +
>>  arch/arm/dts/at91-sama5d4_wifx_l1.dts         | 358 ++++++++++++++++++
>>  arch/arm/dts/sama5d4.dtsi                     |   9 +
>>  arch/arm/mach-at91/Kconfig                    |  11 +
>>  arch/arm/mach-at91/Makefile                   |   3 +-
>>  arch/arm/mach-at91/bootm-barebox.c            |   3 +-
>>  arch/arm/mach-at91/ddramc.c                   |   7 +
>>  arch/arm/mach-at91/include/mach/barebox-arm.h |  22 +-
>>  arch/arm/mach-at91/include/mach/cpu.h         |   1 -
>>  arch/arm/mach-at91/include/mach/ddramc.h      |   1 +
>>  .../mach-at91/include/mach/sama5_bootsource.h |   5 +
>>  arch/arm/mach-at91/sama5_bootsource.c         |  36 ++
>>  arch/arm/mach-at91/sama5d2.c                  |  15 -
>>  arch/arm/mach-at91/setup.c                    |   3 -
>>  common/Makefile                               |   2 +-
>>  drivers/eeprom/at24.c                         |   2 +
>>  drivers/i2c/busses/i2c-at91.c                 |  14 +-
>>  drivers/net/macb.c                            |   1 +
>>  drivers/pinctrl/pinctrl-at91.c                |  20 +-
>>  images/Makefile.at91                          |   4 +
>>  include/deep-probe.h                          |   7 +
>>  include/driver.h                              |  13 +-
>>  30 files changed, 571 insertions(+), 48 deletions(-)
>>  create mode 100644 arch/arm/boards/sama5d4_wifx/Makefile
>>  create mode 100644 arch/arm/boards/sama5d4_wifx/board.c
>>  create mode 100644 arch/arm/boards/sama5d4_wifx/lowlevel.c
>>  create mode 100644 arch/arm/dts/at91-sama5d4_wifx_l1.dts
>>  create mode 100644 arch/arm/dts/sama5d4.dtsi
>>  create mode 100644 arch/arm/mach-at91/sama5_bootsource.c
>>
>> -- 
>> 2.30.2
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |