Re: [PATCH 00/11] ARM: at91: sama5d4: add basic Wifx L1 support

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Sam,

On 28.12.22 11:46, Sam Ravnborg wrote:
>>> The DT file in patch 11 looks like a file that would be a good linux
>>> kernel candidate - but I guess this is for someone else to do.
>>
>> It's on the bucket list, but first barebox, DistroKit and then eventually
>> upstreaming the kernel DT.
> Hopefully there is a fist stage bootloader somewhere in the todo list.
> I really like how this works with PBL and multi image - it is very elegant
> in barebox and then at91bootstrap is no longer required.

I tried to get first stage support on SD working with SAMA5D4, but the
same code that works on SAMA5D3, doesn't for D4 and I didn't have time
to debug this yet. Will probably need a logic analyzer to verify the
assumptions we had with with the D3 hold on D4 too (SD card bus width
configured, SD card frequency, ... etc.).

NAND isn't on my roadmap though, I will use at91bootstrap for that.

>>> I look forward to the day where the remaining three sama5d boards are all
>>> multi-board and DT-enabled. This patch-set brings us a step closer.
>>
>> I don't have the boards, that are not yet DT-enabled, but I guess due
>> diligence is done if we verify that the DT-enabled drivers work on some
>> other SAMA5 board, which already has DT support. Now, with the NAND
>> driver I ported for this, there remain three drivers that I have so
>> far not tested:
>>
>> LCD, PWM and USB (Both Host/Gadget).
>>
>> If you tell me, that all these already work just fine for some SAMA5 with
>> DT (or that they didn't work at all for SAMA5 without DT), I can send the
>> patch series switching the remaining boards to multi-image.
> 
> I have a sama5d4 eXplained board - but the display no longer works.
> I will try to take a look at DT enabling the board if I find time.
> We can revisit what to do then, if you do not beat me to it before.

The only D4 board I have doesn't have a display, so I am not likely to
do anything here soon.

>>> Do you know if there is a way to read bootsource from an at91sam92XX
>>> CPU / ROMBOOT code?
>>
>> I just observed that the info is in r4 on all SAMA5 SoCs. Maybe that's
>> the case for the older SoCs too?
> Looking at at91bootstrap I do not have high hopes.
> Only the sama5 chips have this code enabled.
> (Looked at v3.9.3 - which is the latest with at91sam9x support).

It used to be enabled only for SAMA5D3 although D4 and D2 shared the same
mechanism. I wouldn't take absence in at91bootstrap as indication.

I'd suggest to just stick:

	register u32 r4 asm("r4");
	puthex_ll(r4);

into your board's naked entry point and see for yourself.

Cheers,
Ahmad


> 
> 	Sam
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |