mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Trent Piepho <trent.piepho@igorinstitute.com>,
	Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 4/9] ARM: i.MX: extend drivers for i.MX8MN (Nano) support
Date: Wed, 15 Sep 2021 12:36:55 +0200	[thread overview]
Message-ID: <626fde06-86e7-662b-7a84-8e162a7f12a3@pengutronix.de> (raw)
In-Reply-To: <CAMHeXxP7Zg9r7fXYCzSYF-AZZAKmnxXMeG9uQqz5abP3BYiH8A@mail.gmail.com>

On 08.09.21 21:01, Trent Piepho wrote:
> On Sun, Sep 5, 2021 at 6:52 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>>
>> Extend match tables and function definitions for i.MX USB, ATF,
>> MCI, NVMEM, pinctrl and serial drivers for the i.MX8M Nano.
>>
>> There is no special handling required for those, compared with
>> the mini.
> 
> It shouldn't be necessary to add them when there is no special
> handling.  The device tree should list the earlier type they are
> compatible with as well.  For example, every fsl,imx8*-usdhc I see in
> a device tree then lists fsl,imx7d-usdhc additionally.

I agree. I just searched for imx8mm and replicated the lines.

> Though the Barebox driver does NOT list fsl,imx7d-usdhc.  It works on
> the fsl,imx7d-usdhc because that is compatible with the
> fsl,imx6sl-usdhc.
> 
> Really, the error would seem to be the NXP devicetrees only listing
> imx7d as a compatible instead of going back to imx6sl.

The upstream device trees could be extended, but that's out of scope
for barebox support. I don't think we should hardcode this into
the barebox device tree.

> It is also interesting that in Barebox, the imx7d uses the imx6sl
> compat entry, and that entry includes ESDHC_FLAG_ERR004536.  While the
> imx8* is supposedly imx7d compatible, it uses the imx6sx entry that
> lacks that flag.  I think the error here is that imx7d does not have
> this erratum.

But barebox doesn't seem to do anything different respective to that
flag.

What would you suggest we do here (in barebox)?

Cheers,
Ahmad

> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-09-15 10:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-05 13:51 [PATCH 0/9] ARM: i.MX8M: add nano support Ahmad Fatoum
2021-09-05 13:51 ` [PATCH 1/9] ARM: i.MX: add i.MX8MN (Nano) SoC support boilerplate Ahmad Fatoum
2021-09-05 13:51 ` [PATCH 2/9] clk: imx: add i.MX8MN (Nano) support Ahmad Fatoum
2021-09-05 13:51 ` [PATCH 3/9] ARM: i.MX8MN: adapt early clock support Ahmad Fatoum
2021-09-05 13:51 ` [PATCH 4/9] ARM: i.MX: extend drivers for i.MX8MN (Nano) support Ahmad Fatoum
     [not found]   ` <CAMHeXxN_P3pVSAStL2Z=8La_ioGHNu2hw9qQyFYAJ1VNA8hiEQ@mail.gmail.com>
2021-09-08 19:01     ` Trent Piepho
2021-09-15 10:36       ` Ahmad Fatoum [this message]
2021-09-05 13:51 ` [PATCH 5/9] ARM: i.MX8MM: correct unrecognized fracpll frequency Ahmad Fatoum
     [not found]   ` <CAMHeXxPV_5mzAH3gbpy4WrL16kSstkLhJvx-VUQqbmy9C1r6WQ@mail.gmail.com>
2021-09-08 19:00     ` Trent Piepho
2021-09-15 10:39       ` Ahmad Fatoum
2021-09-24  3:12         ` Trent Piepho
2021-09-05 13:51 ` [PATCH 6/9] ddr: imx8m: add i.MX8MN (Nano) support Ahmad Fatoum
2021-09-05 13:51 ` [PATCH 7/9] ddr: imx8m: ddrphy_train: add DDR4 support Ahmad Fatoum
2021-09-05 13:51 ` [PATCH 8/9] scripts: imx: add i.MX8MN support to imx-image Ahmad Fatoum
2021-09-05 13:51 ` [PATCH 9/9] ARM: i.MX8MN: add i.MX8MN-EVK support Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=626fde06-86e7-662b-7a84-8e162a7f12a3@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=trent.piepho@igorinstitute.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox