mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] devinfo: Omit parent if direct descendent of bus
@ 2021-11-29  7:15 Ahmad Fatoum
  2021-11-29  8:07 ` Ahmad Fatoum
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2021-11-29  7:15 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

In that case parentage adds no extra info, so we can just omit it.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 commands/devinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/devinfo.c b/commands/devinfo.c
index 2e2e48e42cc5..b4894cc9272d 100644
--- a/commands/devinfo.c
+++ b/commands/devinfo.c
@@ -85,7 +85,7 @@ static int do_devinfo(int argc, char *argv[])
 		if (dev->info)
 			dev->info(dev);
 
-		if (dev->parent)
+		if (dev->parent && dev->parent != dev->bus->dev)
 			printf("Parent: %s\n", dev_name(dev->parent));
 
 		first = true;
-- 
2.33.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] devinfo: Omit parent if direct descendent of bus
  2021-11-29  7:15 [PATCH] devinfo: Omit parent if direct descendent of bus Ahmad Fatoum
@ 2021-11-29  8:07 ` Ahmad Fatoum
  0 siblings, 0 replies; 2+ messages in thread
From: Ahmad Fatoum @ 2021-11-29  8:07 UTC (permalink / raw)
  To: Ahmad Fatoum, barebox

On 29.11.21 08:15, Ahmad Fatoum wrote:
> In that case parentage adds no extra info, so we can just omit it.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---

Please dismiss. Sent out a (misnamed) v2 just now.

>  commands/devinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/commands/devinfo.c b/commands/devinfo.c
> index 2e2e48e42cc5..b4894cc9272d 100644
> --- a/commands/devinfo.c
> +++ b/commands/devinfo.c
> @@ -85,7 +85,7 @@ static int do_devinfo(int argc, char *argv[])
>  		if (dev->info)
>  			dev->info(dev);
>  
> -		if (dev->parent)
> +		if (dev->parent && dev->parent != dev->bus->dev)
>  			printf("Parent: %s\n", dev_name(dev->parent));
>  
>  		first = true;
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-29  8:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29  7:15 [PATCH] devinfo: Omit parent if direct descendent of bus Ahmad Fatoum
2021-11-29  8:07 ` Ahmad Fatoum

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git