mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] base: driver: fix double removal of child devices
@ 2021-09-13  8:29 Ahmad Fatoum
  2021-09-13 10:08 ` Jules Maselbas
  0 siblings, 1 reply; 3+ messages in thread
From: Ahmad Fatoum @ 2021-09-13  8:29 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Child devices like an ext4 file system on a partition may be removed
twice: Once because they're in the active devices list and then once
more, because unregister_device is called for the children of its parent.

As struct bus_type::remove clears association of a driver with its
device, we can set struct device_d::driver to NULL. unregister_device
will then skip the second dev->bus->remove.

Fixes: 29f1c211d86c ("fs: don't free device in remove callback")
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 drivers/base/driver.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index 0e04ef36868d..0fedb30161b4 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -512,7 +512,10 @@ static void devices_shutdown(void)
 
 	list_for_each_entry(dev, &active, active) {
 		if (dev->bus->remove)
+		if (dev->bus->remove) {
 			dev->bus->remove(dev);
+			dev->driver = NULL;
+		}
 	}
 }
 devshutdown_exitcall(devices_shutdown);
-- 
2.33.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH master] base: driver: fix double removal of child devices
  2021-09-13  8:29 [PATCH master] base: driver: fix double removal of child devices Ahmad Fatoum
@ 2021-09-13 10:08 ` Jules Maselbas
  2021-09-13 10:18   ` Ahmad Fatoum
  0 siblings, 1 reply; 3+ messages in thread
From: Jules Maselbas @ 2021-09-13 10:08 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

Hi Ahmad,

On Mon, Sep 13, 2021 at 10:29:42AM +0200, Ahmad Fatoum wrote:
> Child devices like an ext4 file system on a partition may be removed
> twice: Once because they're in the active devices list and then once
> more, because unregister_device is called for the children of its parent.
> 
> As struct bus_type::remove clears association of a driver with its
> device, we can set struct device_d::driver to NULL. unregister_device
> will then skip the second dev->bus->remove.
> 
> Fixes: 29f1c211d86c ("fs: don't free device in remove callback")
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  drivers/base/driver.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/base/driver.c b/drivers/base/driver.c
> index 0e04ef36868d..0fedb30161b4 100644
> --- a/drivers/base/driver.c
> +++ b/drivers/base/driver.c
> @@ -512,7 +512,10 @@ static void devices_shutdown(void)
>  
>  	list_for_each_entry(dev, &active, active) {
>  		if (dev->bus->remove)
> +		if (dev->bus->remove) {
I think there is a typo here, this line is duplicated.

>  			dev->bus->remove(dev);
> +			dev->driver = NULL;
> +		}
>  	}
>  }
>  devshutdown_exitcall(devices_shutdown);
> -- 
> 2.33.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 
> 





_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH master] base: driver: fix double removal of child devices
  2021-09-13 10:08 ` Jules Maselbas
@ 2021-09-13 10:18   ` Ahmad Fatoum
  0 siblings, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2021-09-13 10:18 UTC (permalink / raw)
  To: Jules Maselbas, Ahmad Fatoum; +Cc: barebox

Hello Jules,

On 13.09.21 12:08, Jules Maselbas wrote:
> Hi Ahmad,
> 
> On Mon, Sep 13, 2021 at 10:29:42AM +0200, Ahmad Fatoum wrote:
>> Child devices like an ext4 file system on a partition may be removed
>> twice: Once because they're in the active devices list and then once
>> more, because unregister_device is called for the children of its parent.
>>
>> As struct bus_type::remove clears association of a driver with its
>> device, we can set struct device_d::driver to NULL. unregister_device
>> will then skip the second dev->bus->remove.
>>
>> Fixes: 29f1c211d86c ("fs: don't free device in remove callback")
>> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
>> ---
>>  drivers/base/driver.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/base/driver.c b/drivers/base/driver.c
>> index 0e04ef36868d..0fedb30161b4 100644
>> --- a/drivers/base/driver.c
>> +++ b/drivers/base/driver.c
>> @@ -512,7 +512,10 @@ static void devices_shutdown(void)
>>  
>>  	list_for_each_entry(dev, &active, active) {
>>  		if (dev->bus->remove)
>> +		if (dev->bus->remove) {
> I think there is a typo here, this line is duplicated.

You're right. It still worked because the condition was duplicated... ^^'

I sent out a revised v2.

Thanks,
Ahmad

> 
>>  			dev->bus->remove(dev);
>> +			dev->driver = NULL;
>> +		}
>>  	}
>>  }
>>  devshutdown_exitcall(devices_shutdown);
>> -- 
>> 2.33.0
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
>>
> 
> 
> 
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-13 10:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13  8:29 [PATCH master] base: driver: fix double removal of child devices Ahmad Fatoum
2021-09-13 10:08 ` Jules Maselbas
2021-09-13 10:18   ` Ahmad Fatoum

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git