mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Trent Piepho <>
To: Oleksij Rempel <>
Cc: Barebox List <>
Subject: Re: [PATCH v2 2/2] net: phy: micrel: sync init code for ksz80xx variants with the kernel driver
Date: Wed, 13 Oct 2021 03:25:17 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Oct 13, 2021 at 2:43 AM Oleksij Rempel <> wrote:
> Sync part of barebox micrel driver with the kernel v5.15-rc1.
> This change will affect most of by barebox supported 100Mbit/ksz80xx PHY
> variants and provide unified devicetree support for LED and clock configuration.

I already added LED mode OF support to this driver.

>  drivers/net/phy/micrel.c | 249 +++++++++++++++++++++++++++++++++++----
>  1 file changed, 228 insertions(+), 21 deletions(-)

227 added lines is a lot to do basically nothing not already done.

>  #define KSZ8051_RMII_50MHZ_CLK                 BIT(7)
> +#define KSZPHY_RMII_REF_CLK_SEL                        BIT(7)

These are the same bit in the same register!

barebox mailing list

  reply	other threads:[~2021-10-13 11:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13  7:53 [PATCH v2 1/2] include/phy: add driver_data to resume more of kernel code Oleksij Rempel
2021-10-13  7:53 ` [PATCH v2 2/2] net: phy: micrel: sync init code for ksz80xx variants with the kernel driver Oleksij Rempel
2021-10-13 10:25   ` Trent Piepho [this message]
2021-10-13 11:19     ` Oleksij Rempel
2021-10-14 20:32       ` Trent Piepho
2021-10-15  6:36         ` Oleksij Rempel
2021-10-15  7:11         ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox