From: Alexander Shiyan <eagle.alexander923@gmail.com> To: Sascha Hauer <sha@pengutronix.de> Cc: Barebox List <barebox@lists.infradead.org> Subject: Re: [RFC 2/2] clocksource: arm_global_timer: Convert driver to use clocksource context field Date: Fri, 10 Jun 2022 12:53:28 +0300 [thread overview] Message-ID: <CAP1tNvR7myvDfz+kLx1+VG-WmBJ1KF6RKgv0Fea2R2oHQmVWjQ@mail.gmail.com> (raw) In-Reply-To: <20220610094029.GM1615@pengutronix.de> пт, 10 июн. 2022 г. в 12:40, Sascha Hauer <sha@pengutronix.de>: > > On Fri, Jun 10, 2022 at 11:56:32AM +0300, Alexander Shiyan wrote: > > Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com> > > --- > > drivers/clocksource/arm_global_timer.c | 27 +++++++++++++++----------- > > 1 file changed, 16 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c > > index 6e2fae9ba4..3e9b90059a 100644 > > --- a/drivers/clocksource/arm_global_timer.c > > +++ b/drivers/clocksource/arm_global_timer.c ... > As long as the statically allocated &cs is used it's not really useful > to store the context pointer in there. The meaning here is: With a static clocksource structure, the "ctx" field will be initialized, so it will not allow a second instance of the driver to be loaded (in case of incorrect DTS or something similar). So. this example is just a single instance protector :) I will review the code to understand how to make it easier. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-06-10 10:02 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-10 8:56 [RFC 1/2] clocksource: Introduce a context storage for the clocksource structure Alexander Shiyan 2022-06-10 8:56 ` [RFC 2/2] clocksource: arm_global_timer: Convert driver to use clocksource context field Alexander Shiyan 2022-06-10 9:40 ` Sascha Hauer 2022-06-10 9:53 ` Alexander Shiyan [this message] 2022-06-10 8:56 ` [RFC 0/2] Context storage for the clocksource Alexander Shiyan 2022-06-10 9:35 ` [RFC 1/2] clocksource: Introduce a context storage for the clocksource structure Sascha Hauer 2022-06-10 9:42 ` Alexander Shiyan 2022-06-10 9:44 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAP1tNvR7myvDfz+kLx1+VG-WmBJ1KF6RKgv0Fea2R2oHQmVWjQ@mail.gmail.com \ --to=eagle.alexander923@gmail.com \ --cc=barebox@lists.infradead.org \ --cc=sha@pengutronix.de \ --subject='Re: [RFC 2/2] clocksource: arm_global_timer: Convert driver to use clocksource context field' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox