mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH v1] ARM: protonic: vicut1: disable on-die termination to fix PHY bootstrapping
@ 2021-05-18  8:37 Oleksij Rempel
  2021-05-25  4:58 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2021-05-18  8:37 UTC (permalink / raw)
  To: barebox; +Cc: Oleksij Rempel, Robin van der Gracht

If on-die termination is enabled, the RXC pin of iMX6 will be pulled
high. Since we already have an 10K pull-down on board, the RXC level on
PHY reset will be ~800mV, which is mostly interpreted as 1. On some
reboots we get 0 instead and kernel can't detect the PHY properly.

Since the default 0x020e07ac value is 0, it is sufficient to remove this
entry from the affected imxcfg files.

Since we get stable 0 on pin PHYADDR[2], the PHY address is changed from
4 to 0.

Reported-by: Robin van der Gracht <robin@protonic.nl>
Fixes: 00adc1e33ef8 ("ARM: add imx6 based Protonic boads")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boards/protonic-imx6/flash-header-vicut1.imxcfg | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boards/protonic-imx6/flash-header-vicut1.imxcfg b/arch/arm/boards/protonic-imx6/flash-header-vicut1.imxcfg
index 9926fbf4a2..54f655c4c2 100644
--- a/arch/arm/boards/protonic-imx6/flash-header-vicut1.imxcfg
+++ b/arch/arm/boards/protonic-imx6/flash-header-vicut1.imxcfg
@@ -114,7 +114,6 @@ wm 32 0x020e001c 0x007f007f
 
 /* RGMII config */
 wm 32 0x020e0768 0x00080000 /* 1V2 DDR IO */
-wm 32 0x020e0788 0x00000200 /* 60 Ohm ODT */
 
 /* Debug */
 wm 32 0x020e023c 0x00000005
-- 
2.29.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] ARM: protonic: vicut1: disable on-die termination to fix PHY bootstrapping
  2021-05-18  8:37 [PATCH v1] ARM: protonic: vicut1: disable on-die termination to fix PHY bootstrapping Oleksij Rempel
@ 2021-05-25  4:58 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-05-25  4:58 UTC (permalink / raw)
  To: Oleksij Rempel; +Cc: barebox, Robin van der Gracht

On Tue, May 18, 2021 at 10:37:07AM +0200, Oleksij Rempel wrote:
> If on-die termination is enabled, the RXC pin of iMX6 will be pulled
> high. Since we already have an 10K pull-down on board, the RXC level on
> PHY reset will be ~800mV, which is mostly interpreted as 1. On some
> reboots we get 0 instead and kernel can't detect the PHY properly.
> 
> Since the default 0x020e07ac value is 0, it is sufficient to remove this
> entry from the affected imxcfg files.
> 
> Since we get stable 0 on pin PHYADDR[2], the PHY address is changed from
> 4 to 0.
> 
> Reported-by: Robin van der Gracht <robin@protonic.nl>
> Fixes: 00adc1e33ef8 ("ARM: add imx6 based Protonic boads")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/boards/protonic-imx6/flash-header-vicut1.imxcfg | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-25  4:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18  8:37 [PATCH v1] ARM: protonic: vicut1: disable on-die termination to fix PHY bootstrapping Oleksij Rempel
2021-05-25  4:58 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git