mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Andrej Picej <andrej.picej@norik.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] regulator: fix memory leak
Date: Tue, 1 Mar 2022 09:47:58 +0100	[thread overview]
Message-ID: <20220301084758.GP19585@pengutronix.de> (raw)
In-Reply-To: <5d436fc3-fc64-1b68-1a72-510462e08686@norik.com>

On Tue, Mar 01, 2022 at 09:21:34AM +0100, Andrej Picej wrote:
> Gentle ping. The patch was probably missed as is was send as an reply to
> Trent's memory leak find.
> 
> On 19. 11. 21 14:06, Andrej Picej wrote:
> > Fix memory leak of propname.
> > 
> > Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> > ---
> >   drivers/regulator/core.c | 6 ++++--
> >   1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> > index 097f7d779..c5cb9ee34 100644
> > --- a/drivers/regulator/core.c
> > +++ b/drivers/regulator/core.c
> > @@ -231,8 +231,10 @@ static struct regulator_internal *of_regulator_get(struct device_d *dev, const c
> >   	}
> >   	ret = of_device_ensure_probed(node);
> > -	if (ret)
> > -		return ERR_PTR(ret);
> > +	if (ret) {
> > +		ri = ERR_PTR(ret);
> > +		goto out;
> > +	}

This conflicts with b720625659 ("regulator: allow use of dummy regulator").
I fixed this up, see the result in next.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2022-03-01  8:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  9:54 [PATCH v2 0/6] PHYTEC patches to be mainlined Andrej Picej
2021-11-19  9:54 ` [PATCH v2 1/6] flash-header-phytec-pcl063: Set SOC voltage to 1.25 V during boot Andrej Picej
2021-11-19  9:54 ` [PATCH v2 2/6] ARM: configs: imx_v7_defconfig: add OF commands Andrej Picej
2021-11-19  9:54 ` [PATCH v2 3/6] ARM: configs: imx_v7_defconfig: add OCOTP write support Andrej Picej
2021-11-19  9:54 ` [PATCH v2 4/6] regulator: allow use of dummy regulator Andrej Picej
2021-11-19 10:49   ` Trent Piepho
2021-11-19 12:35     ` Andrej Picej
2021-11-19 13:06     ` [PATCH] regulator: fix memory leak Andrej Picej
2022-03-01  8:21       ` Andrej Picej
2022-03-01  8:47         ` Sascha Hauer [this message]
2022-03-01  9:01           ` Andrej Picej
2021-11-19  9:54 ` [PATCH v2 5/6] ARM: dts: imx6qdl: pfla02: use dummy regulators Andrej Picej
2021-11-19  9:54 ` [PATCH v2 6/6] documentation: regulator: add allow-dummy-supply Andrej Picej
2021-11-25  7:30 ` [PATCH v2 0/6] PHYTEC patches to be mainlined Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301084758.GP19585@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=andrej.picej@norik.com \
    --cc=barebox@lists.infradead.org \
    --subject='Re: [PATCH] regulator: fix memory leak' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox