mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrej Picej <andrej.picej@norik.com>
To: Trent Piepho <trent.piepho@igorinstitute.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 4/6] regulator: allow use of dummy regulator
Date: Fri, 19 Nov 2021 13:35:59 +0100	[thread overview]
Message-ID: <db386b55-9e27-f097-10f7-91bd3a9c1515@norik.com> (raw)
In-Reply-To: <CAMHeXxPD9eOdamfmB84e76YtMrifo663zt7cnDN7Qd=iENQdfA@mail.gmail.com>



On 19. 11. 21 11:49, Trent Piepho wrote:
> On Fri, Nov 19, 2021 at 1:55 AM Andrej Picej <andrej.picej@norik.com> wrote:
>>
>>          ret = of_device_ensure_probed(node);
>> -       if (ret)
>> +       if (ret) {
>> +               /*
>> +                * If "barebox,allow-dummy-supply" property is set for regulator
>> +                * provider allow use of dummy regulator (NULL is returned).
>> +                * Check regulator node and its parent if this setting is set
>> +                * PMIC wide.
>> +                */
>> +               node_parent = of_get_parent(node);
>> +               if (of_get_property(node, "barebox,allow-dummy-supply", NULL) ||
>> +                   of_get_property(node_parent, "barebox,allow-dummy-supply", NULL)) {
>> +                       dev_dbg(dev, "Allow use of dummy regulator for " \
>> +                               "%s-supply\n", supply);
>> +                       ri = NULL;
>> +                       goto out;
>> +               }
>> +
>>                  return ERR_PTR(ret);
> 
> This return, which was added in "common: add initial barebox
> deep-probe support", is a memory leak of propname.  It should be goto
> out.
> 

You are right, if that's ok I will create a separate patch for that.

BR, Andrej

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-11-19 12:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  9:54 [PATCH v2 0/6] PHYTEC patches to be mainlined Andrej Picej
2021-11-19  9:54 ` [PATCH v2 1/6] flash-header-phytec-pcl063: Set SOC voltage to 1.25 V during boot Andrej Picej
2021-11-19  9:54 ` [PATCH v2 2/6] ARM: configs: imx_v7_defconfig: add OF commands Andrej Picej
2021-11-19  9:54 ` [PATCH v2 3/6] ARM: configs: imx_v7_defconfig: add OCOTP write support Andrej Picej
2021-11-19  9:54 ` [PATCH v2 4/6] regulator: allow use of dummy regulator Andrej Picej
2021-11-19 10:49   ` Trent Piepho
2021-11-19 12:35     ` Andrej Picej [this message]
2021-11-19 13:06     ` [PATCH] regulator: fix memory leak Andrej Picej
2022-03-01  8:21       ` Andrej Picej
2022-03-01  8:47         ` Sascha Hauer
2022-03-01  9:01           ` Andrej Picej
2021-11-19  9:54 ` [PATCH v2 5/6] ARM: dts: imx6qdl: pfla02: use dummy regulators Andrej Picej
2021-11-19  9:54 ` [PATCH v2 6/6] documentation: regulator: add allow-dummy-supply Andrej Picej
2021-11-25  7:30 ` [PATCH v2 0/6] PHYTEC patches to be mainlined Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db386b55-9e27-f097-10f7-91bd3a9c1515@norik.com \
    --to=andrej.picej@norik.com \
    --cc=barebox@lists.infradead.org \
    --cc=trent.piepho@igorinstitute.com \
    --subject='Re: [PATCH v2 4/6] regulator: allow use of dummy regulator' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox