mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Trent Piepho <trent.piepho@igorinstitute.com>
To: Andrej Picej <andrej.picej@norik.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 4/6] regulator: allow use of dummy regulator
Date: Fri, 19 Nov 2021 02:49:58 -0800
Message-ID: <CAMHeXxPD9eOdamfmB84e76YtMrifo663zt7cnDN7Qd=iENQdfA@mail.gmail.com> (raw)
In-Reply-To: <20211119095429.1905473-5-andrej.picej@norik.com>

On Fri, Nov 19, 2021 at 1:55 AM Andrej Picej <andrej.picej@norik.com> wrote:
>
>         ret = of_device_ensure_probed(node);
> -       if (ret)
> +       if (ret) {
> +               /*
> +                * If "barebox,allow-dummy-supply" property is set for regulator
> +                * provider allow use of dummy regulator (NULL is returned).
> +                * Check regulator node and its parent if this setting is set
> +                * PMIC wide.
> +                */
> +               node_parent = of_get_parent(node);
> +               if (of_get_property(node, "barebox,allow-dummy-supply", NULL) ||
> +                   of_get_property(node_parent, "barebox,allow-dummy-supply", NULL)) {
> +                       dev_dbg(dev, "Allow use of dummy regulator for " \
> +                               "%s-supply\n", supply);
> +                       ri = NULL;
> +                       goto out;
> +               }
> +
>                 return ERR_PTR(ret);

This return, which was added in "common: add initial barebox
deep-probe support", is a memory leak of propname.  It should be goto
out.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-11-19 10:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  9:54 [PATCH v2 0/6] PHYTEC patches to be mainlined Andrej Picej
2021-11-19  9:54 ` [PATCH v2 1/6] flash-header-phytec-pcl063: Set SOC voltage to 1.25 V during boot Andrej Picej
2021-11-19  9:54 ` [PATCH v2 2/6] ARM: configs: imx_v7_defconfig: add OF commands Andrej Picej
2021-11-19  9:54 ` [PATCH v2 3/6] ARM: configs: imx_v7_defconfig: add OCOTP write support Andrej Picej
2021-11-19  9:54 ` [PATCH v2 4/6] regulator: allow use of dummy regulator Andrej Picej
2021-11-19 10:49   ` Trent Piepho [this message]
2021-11-19 12:35     ` Andrej Picej
2021-11-19 13:06     ` [PATCH] regulator: fix memory leak Andrej Picej
2021-11-19  9:54 ` [PATCH v2 5/6] ARM: dts: imx6qdl: pfla02: use dummy regulators Andrej Picej
2021-11-19  9:54 ` [PATCH v2 6/6] documentation: regulator: add allow-dummy-supply Andrej Picej
2021-11-25  7:30 ` [PATCH v2 0/6] PHYTEC patches to be mainlined Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMHeXxPD9eOdamfmB84e76YtMrifo663zt7cnDN7Qd=iENQdfA@mail.gmail.com' \
    --to=trent.piepho@igorinstitute.com \
    --cc=andrej.picej@norik.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git