mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH v3 1/2] fastboot: always try barebox_update handler for bbu- partitions
@ 2022-06-09 13:09 Ahmad Fatoum
  2022-06-09 13:09 ` [PATCH v3 2/2] fastboot: bail if update handler couldn't be found for bbu-partition Ahmad Fatoum
  2022-06-10  8:35 ` [PATCH v3 1/2] fastboot: always try barebox_update handler for bbu- partitions Sascha Hauer
  0 siblings, 2 replies; 8+ messages in thread
From: Ahmad Fatoum @ 2022-06-09 13:09 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

So far, fastboot barebox_update code was only entered when
filetype_is_barebox_image() returned true, a function exclusively used
for fastboot. Align this with normal barebox_update from the command
line by leaving the decision on whether the image is correctly to the
barebox_update handler if the user explicitly targets a bbu- fastboot
partition.

We keep the old check OR-ed to maintain backwards-compatibility for
invoking barebox_update for non bbu- fastboot partitions.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v2 -> v3:
  - no changes
v1 -> v2:
  - new patch (Sascha)
---
 common/fastboot.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/fastboot.c b/common/fastboot.c
index f8ed40c86e00..330a06f5a32f 100644
--- a/common/fastboot.c
+++ b/common/fastboot.c
@@ -673,7 +673,8 @@ static void cb_flash(struct fastboot *fb, const char *cmd)
 		goto out;
 	}
 
-	if (IS_ENABLED(CONFIG_BAREBOX_UPDATE) && filetype_is_barebox_image(filetype)) {
+	if (IS_ENABLED(CONFIG_BAREBOX_UPDATE) &&
+	    (filetype_is_barebox_image(filetype) || strstarts(fentry->name, "bbu-"))) {
 		void *buf;
 		struct bbu_handler *handler;
 		struct bbu_data data = {
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-06-10  8:36 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 13:09 [PATCH v3 1/2] fastboot: always try barebox_update handler for bbu- partitions Ahmad Fatoum
2022-06-09 13:09 ` [PATCH v3 2/2] fastboot: bail if update handler couldn't be found for bbu-partition Ahmad Fatoum
2022-06-09 13:11   ` [PATCH] fixup! " Ahmad Fatoum
2022-06-09 14:10   ` [PATCH v3 2/2] " Sascha Hauer
2022-06-09 14:12     ` Ahmad Fatoum
2022-06-10  6:36       ` Michael Olbrich
2022-06-10  6:57         ` Sascha Hauer
2022-06-10  8:35 ` [PATCH v3 1/2] fastboot: always try barebox_update handler for bbu- partitions Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox