* [PATCH] common: bootm: print error in case of appendroot failed
@ 2022-07-04 14:18 Marco Felsch
2022-07-05 8:19 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Marco Felsch @ 2022-07-04 14:18 UTC (permalink / raw)
To: barebox
Inform the user that appendroot failed instead of silently dropping the
request. This makes the debugging easier e.g. if nt-signature wasn't set
correctly.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
common/bootm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/bootm.c b/common/bootm.c
index 3c80e8bf94..1c722afc80 100644
--- a/common/bootm.c
+++ b/common/bootm.c
@@ -729,6 +729,8 @@ int bootm_boot(struct bootm_data *bootm_data)
globalvar_add_simple("linux.bootargs.bootm.appendroot",
rootarg);
free(rootarg);
+ } else {
+ pr_err("Failed to append kernel cmdline parameter 'root='\n");
}
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] common: bootm: print error in case of appendroot failed
2022-07-04 14:18 [PATCH] common: bootm: print error in case of appendroot failed Marco Felsch
@ 2022-07-05 8:19 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-07-05 8:19 UTC (permalink / raw)
To: Marco Felsch; +Cc: barebox
On Mon, Jul 04, 2022 at 04:18:09PM +0200, Marco Felsch wrote:
> Inform the user that appendroot failed instead of silently dropping the
> request. This makes the debugging easier e.g. if nt-signature wasn't set
> correctly.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> common/bootm.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/common/bootm.c b/common/bootm.c
> index 3c80e8bf94..1c722afc80 100644
> --- a/common/bootm.c
> +++ b/common/bootm.c
> @@ -729,6 +729,8 @@ int bootm_boot(struct bootm_data *bootm_data)
> globalvar_add_simple("linux.bootargs.bootm.appendroot",
> rootarg);
> free(rootarg);
> + } else {
> + pr_err("Failed to append kernel cmdline parameter 'root='\n");
> }
> }
>
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-05 8:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 14:18 [PATCH] common: bootm: print error in case of appendroot failed Marco Felsch
2022-07-05 8:19 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox