mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@wolfvision.net>
To: barebox@lists.infradead.org
Cc: Frank Wunderlich <frank-w@public-files.de>,
	Michael Riesch <michael.riesch@wolfvision.net>
Subject: [PATCH v2 5/7] arm: rockchip: rk3568-bpi-r2pro: remove io domain configuration
Date: Mon, 19 Sep 2022 13:39:46 +0200	[thread overview]
Message-ID: <20220919113948.991245-6-michael.riesch@wolfvision.net> (raw)
In-Reply-To: <20220919113948.991245-1-michael.riesch@wolfvision.net>

Let the recently added Rockchip IO domain driver configure the IO
domains instead of setting the bits in rk3568_start().

Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
 arch/arm/boards/rockchip-rk3568-bpi-r2pro/lowlevel.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/arm/boards/rockchip-rk3568-bpi-r2pro/lowlevel.c b/arch/arm/boards/rockchip-rk3568-bpi-r2pro/lowlevel.c
index f79f975080..36f7acd7d0 100644
--- a/arch/arm/boards/rockchip-rk3568-bpi-r2pro/lowlevel.c
+++ b/arch/arm/boards/rockchip-rk3568-bpi-r2pro/lowlevel.c
@@ -15,15 +15,6 @@ static noinline void rk3568_start(void)
 {
 	void *fdt;
 
-	/*
-	 * set iodomain vccio6 to 1.8V needed for GMAC1 to work.
-	 * vccio4 (gmac0/switch) needs to stay at 3v3 (default)
-	 */
-	//set bit 6 in PMU_GRF_IO_VSEL0 for vccio6 1v8
-	writel(RK_SETBITS(BIT(6)), PMU_GRF_IO_VSEL0);
-	//clear bit 6 for 3v3 as it was set to 1v8
-	writel(RK_CLRBITS(BIT(6)), PMU_GRF_IO_VSEL1);
-
 	fdt = __dtb_rk3568_bpi_r2_pro_start;
 
 	if (current_el() == 3) {
-- 
2.30.2




  parent reply	other threads:[~2022-09-19 11:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 11:39 [PATCH v2 0/7] soc: rockchip: add driver for rockchip io domains Michael Riesch
2022-09-19 11:39 ` [PATCH v2 1/7] " Michael Riesch
2022-09-21  9:46   ` Sascha Hauer
2022-09-21 11:49     ` Michael Riesch
2022-09-22  8:03       ` Sascha Hauer
2022-09-22  8:13         ` Ahmad Fatoum
2022-09-22  8:23           ` Sascha Hauer
2022-09-19 11:39 ` [PATCH v2 2/7] arm: rockchip_v8_defconfig: enable io domain driver Michael Riesch
2022-09-19 11:39 ` [PATCH v2 3/7] arm: rockchip: radxa-rock3: remove io domain configuration Michael Riesch
2022-09-19 11:39 ` [PATCH v2 4/7] arm: rockchip: rk3568-evb: " Michael Riesch
2022-09-19 11:39 ` Michael Riesch [this message]
2022-09-19 11:39 ` [PATCH v2 6/7] arm: rockchip: rk3568: refactor common rk3568_start method Michael Riesch
2022-09-21  9:17   ` Sascha Hauer
2022-09-21 11:57     ` Michael Riesch
2022-09-21 12:21       ` Sascha Hauer
2022-09-21 12:34         ` Michael Riesch
2022-09-19 11:39 ` [PATCH v2 7/7] arm: rockchip: rk3568-bpi-r2pro: use common method rk3568_start Michael Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220919113948.991245-6-michael.riesch@wolfvision.net \
    --to=michael.riesch@wolfvision.net \
    --cc=barebox@lists.infradead.org \
    --cc=frank-w@public-files.de \
    --subject='Re: [PATCH v2 5/7] arm: rockchip: rk3568-bpi-r2pro: remove io domain configuration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox