Re: [PATCH v2 1/7] soc: rockchip: add driver for rockchip io domains

[Sascha Hauer <sha@pengutronix.de>]

On Mon, Sep 19, 2022 at 01:39:42PM +0200, Michael Riesch wrote:
> The IO domains in Rockchip SoCs need to be configured to match the
> corresponding bank voltage. In Linux this is achieved by means of a
> platform driver that reads the voltage value of the supplies and
> configures the bits in the general register file (GRF) accordingly.
> Port this driver to barebox to provide support for the Rockchip
> RK356x SoCs.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> ---
>  drivers/soc/Kconfig              |   1 +
>  drivers/soc/Makefile             |   1 +
>  drivers/soc/rockchip/Kconfig     |  17 +++
>  drivers/soc/rockchip/Makefile    |   6 +
>  drivers/soc/rockchip/io-domain.c | 223 +++++++++++++++++++++++++++++++
>  5 files changed, 248 insertions(+)
>  create mode 100644 drivers/soc/rockchip/Kconfig
>  create mode 100644 drivers/soc/rockchip/Makefile
>  create mode 100644 drivers/soc/rockchip/io-domain.c

There's nothing in this driver that makes sure it is probed before the
users of the io domains. What happens when the users are probed before
the io domain driver?

Normally I would expect that the consumers have some phandle to their io
domain, but there's nothing like it in the device trees.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |