mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH v3 5/6] clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK
Date: Tue, 10 Sep 2019 16:07:34 +0200	[thread overview]
Message-ID: <48441ba7-3992-2d4c-be11-46bf4af4db97@pengutronix.de> (raw)
In-Reply-To: <20190910131512.7u5vmtuvi2i4culs@pengutronix.de>

On 9/10/19 3:15 PM, Sascha Hauer wrote:
> Hi Ahmad,
> 
> On Wed, Jul 17, 2019 at 07:06:03PM +0200, Ahmad Fatoum wrote:
>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> Due to incorrect placement of the clock gate cell in the ldb_di[x]_clk
>> tree, the glitchy parent mux of ldb_di[x]_clk can cause a glitch to
>> enter the ldb_di_ipu_div divider. If the divider gets locked up, no
>> ldb_di[x]_clk is generated, and the LVDS display will hang when the
>> ipu_di_clk is sourced from ldb_di_clk.
> 
> I haven't investigates any further, but this one breaks NAND support at
> least on my phyCORE i.MX6 board. With this patch applied we get:
> 
> MXS: Timeout resetting block via register 0x00112000
> mxs_nand 112000.gpmi-nand@112000.of: probe failed: Connection timed out
> 
> Does this patch disable any clocks necessary for NAND?

Running clk_dump on an i.MX6Q shows the gpmi clocks being sourced from
pll2_pfd2_396m. PFD outputs come out of reset ungated, but since this commit
disable_anatop_clocks() gates them.
Apparently, nothing in barebox ungates them again? The commit is a straight
port from the kernel, so I think there's some other upstream change that is
missing. Any idea?

Cheers
Ahmad
 

> 
> Sascha
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-09-10 14:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 17:05 [PATCH v3 0/6] clk: imx6: work around LDB hang caused by ERR009219 Ahmad Fatoum
2019-07-17 17:05 ` [PATCH v3 1/6] clk: imx6: fix use of cpu_is_mx6* before they are initialized Ahmad Fatoum
2019-07-17 17:10   ` Ahmad Fatoum
2019-07-18 15:51     ` Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 2/6] clk: imx6: Mask mmdc_ch1 handshake for periph2_sel and mmdc_ch1_axi_podf Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 3/6] clk: imx6: remove quirky clk_set_parent(LDB_diN_sel, pll5_video_div) Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 4/6] clk: imx6: Make the LDB_DI0 and LDB_DI1 clocks read-only Ahmad Fatoum
2019-07-18  8:19   ` Roland Hieber
2019-07-18  8:25     ` Ahmad Fatoum
2019-07-18  8:33       ` Roland Hieber
2019-08-05 10:22       ` Sascha Hauer
2019-07-17 17:06 ` [PATCH v3 5/6] clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK Ahmad Fatoum
2019-09-10 13:15   ` Sascha Hauer
2019-09-10 14:07     ` Ahmad Fatoum [this message]
2019-07-17 17:06 ` [PATCH v3 6/6] clk: imx6: define an enum for ldb mux inputs Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48441ba7-3992-2d4c-be11-46bf4af4db97@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox