mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/3] watchdog: imxwd: Add error messages for some failure points in .probe()
@ 2022-06-27 10:33 Uwe Kleine-König
  2022-06-27 10:33 ` [PATCH 2/3] clk: imx25: Add comments to clk list with offsets Uwe Kleine-König
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Uwe Kleine-König @ 2022-06-27 10:33 UTC (permalink / raw)
  To: barebox

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/watchdog/imxwd.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/watchdog/imxwd.c b/drivers/watchdog/imxwd.c
index 31ea388c2cf2..3e596b55f8f7 100644
--- a/drivers/watchdog/imxwd.c
+++ b/drivers/watchdog/imxwd.c
@@ -245,12 +245,16 @@ static int imx_wd_probe(struct device_d *dev)
 	}
 
 	clk = clk_get(dev, NULL);
-	if (IS_ERR(clk))
+	if (IS_ERR(clk)) {
+		dev_err(dev, "Failed to get clk: %d\n", PTR_ERR(clk));
 		return PTR_ERR(clk);
+	}
 
 	ret = clk_enable(clk);
-	if (ret)
+	if (ret) {
+		dev_err(dev, "Failed to enable clk: %d\n", ret);
 		return ret;
+	}
 
 	priv->base = IOMEM(iores->start);
 	priv->ops = ops;
@@ -272,14 +276,16 @@ static int imx_wd_probe(struct device_d *dev)
 		}
 
 		ret = watchdog_register(&priv->wd);
-		if (ret)
+		if (ret) {
+			dev_err(dev, "Failed to register watchdog device: %d\n", ret);
 			goto on_error;
+		}
 	}
 
 	if (priv->ops->init) {
 		ret = priv->ops->init(priv);
 		if (ret) {
-			dev_err(dev, "Failed to init watchdog device %d\n", ret);
+			dev_err(dev, "Failed to init watchdog device: %d\n", ret);
 			goto error_unregister;
 		}
 	}

base-commit: 512d036587a38c57a30cc63ce48c19c895b9d729
-- 
2.36.1




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-06-29  8:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-27 10:33 [PATCH 1/3] watchdog: imxwd: Add error messages for some failure points in .probe() Uwe Kleine-König
2022-06-27 10:33 ` [PATCH 2/3] clk: imx25: Add comments to clk list with offsets Uwe Kleine-König
2022-06-27 13:13   ` Alexander Shiyan
2022-06-29  7:40     ` Sascha Hauer
2022-06-27 10:33 ` [PATCH 3/3] clk: imx25: Add support for watchdog clock Uwe Kleine-König
2022-06-27 10:51 ` [PATCH 1/3] watchdog: imxwd: Add error messages for some failure points in .probe() Ahmad Fatoum
2022-06-29  8:54   ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox