From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 2/9] arm: socfgpa: agilex5: remove unused memsize
Date: Thu, 16 Apr 2026 11:48:06 +0200 [thread overview]
Message-ID: <20260416-socfpga-agilex5-sdram-v1-2-07556aa7219f@pengutronix.de> (raw)
In-Reply-To: <20260416-socfpga-agilex5-sdram-v1-0-07556aa7219f@pengutronix.de>
The memsize parameter isn't used when loading the TF-A. Furthermore,
using a fixed memory size may be wrong if inline ecc is enabled, because
inline ecc reduces the amount of usable memory.
Remove the parameter to avoid confusion.
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
arch/arm/boards/arrow-axe5-eagle/lowlevel.c | 2 +-
arch/arm/mach-socfpga/atf.c | 2 +-
include/mach/socfpga/generic.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boards/arrow-axe5-eagle/lowlevel.c b/arch/arm/boards/arrow-axe5-eagle/lowlevel.c
index 6b158305fdb5..41c1b832a682 100644
--- a/arch/arm/boards/arrow-axe5-eagle/lowlevel.c
+++ b/arch/arm/boards/arrow-axe5-eagle/lowlevel.c
@@ -63,7 +63,7 @@ static noinline void axe5_eagle_continue(void)
socfpga_mailbox_s10_init();
socfpga_mailbox_s10_qspi_open();
- agilex5_load_and_start_image_via_tfa(SZ_1G);
+ agilex5_load_and_start_image_via_tfa();
}
fdt = __dtb_z_socfpga_agilex5_axe5_eagle_start;
diff --git a/arch/arm/mach-socfpga/atf.c b/arch/arm/mach-socfpga/atf.c
index 98460472227e..3ad19e33ac94 100644
--- a/arch/arm/mach-socfpga/atf.c
+++ b/arch/arm/mach-socfpga/atf.c
@@ -9,7 +9,7 @@
#include <mach/socfpga/generic.h>
#include <mach/socfpga/soc64-regs.h>
-void __noreturn agilex5_load_and_start_image_via_tfa(unsigned long memsize)
+void __noreturn agilex5_load_and_start_image_via_tfa(void)
{
void *bl31 = (void *)AGILEX5_ATF_BL31_BASE_ADDR;
void *bl33 = (void *)AGILEX5_ATF_BL33_BASE_ADDR;
diff --git a/include/mach/socfpga/generic.h b/include/mach/socfpga/generic.h
index 07add9ed40d6..06768e9ec0a0 100644
--- a/include/mach/socfpga/generic.h
+++ b/include/mach/socfpga/generic.h
@@ -100,7 +100,7 @@ static inline void arria10_watchdog_disable(void) {}
#endif
int agilex5_clk_init(void);
-void __noreturn agilex5_load_and_start_image_via_tfa(unsigned long memsize);
+void __noreturn agilex5_load_and_start_image_via_tfa(void);
static inline void __udelay(unsigned us)
{
--
2.47.3
next prev parent reply other threads:[~2026-04-16 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 9:48 [PATCH 0/9] arm: socfpga: agilex5: rework low level code Michael Tretter
2026-04-16 9:48 ` [PATCH 1/9] arm: socfpga: agilex5: cleanup TF-A loading Michael Tretter
2026-04-16 9:48 ` Michael Tretter [this message]
2026-04-16 9:48 ` [PATCH 3/9] arm: socfpga: agilex5: configure firewall with base and size Michael Tretter
2026-04-16 9:48 ` [PATCH 4/9] arm: socfpga: agilex5: fix read of memory limit Michael Tretter
2026-04-16 9:48 ` [PATCH 5/9] arm: socfpga: agilex5: fix SDRAM size calculation Michael Tretter
2026-04-16 9:48 ` [PATCH 6/9] arm: socfpga: agilex5: remove unused declarations Michael Tretter
2026-04-16 9:48 ` [PATCH 7/9] arm: socfpga: agilex5: read SDRAM limits from firewall Michael Tretter
2026-04-16 9:48 ` [PATCH 8/9] arm: socfpga: agilex5: add agilex5_barebox_entry Michael Tretter
2026-04-16 9:48 ` [PATCH 9/9] arm: socfpga: agilex5: add explicit unreachable after TF-A load Michael Tretter
2026-04-17 8:25 ` [PATCH 0/9] arm: socfpga: agilex5: rework low level code Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416-socfpga-agilex5-sdram-v1-2-07556aa7219f@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox